Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestResponseControllerSetFutureWriteDeadline failures #56807

Closed
gopherbot opened this issue Nov 17, 2022 · 5 comments
Closed

net/http: TestResponseControllerSetFutureWriteDeadline failures #56807

gopherbot opened this issue Nov 17, 2022 · 5 comments
Assignees
@neild
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.20

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "net/http" && test == "TestResponseControllerSetFutureWriteDeadline"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestResponseControllerSetFutureWriteDeadline (0.00s)
    --- FAIL: TestResponseControllerSetFutureWriteDeadline/h1 (0.00s)
        responsecontroller_test.go:146: unexpected connection error: Get "http://127.0.0.1:51242": EOF
2022/11/16 13:41:33 http: TLS handshake error from 127.0.0.1:51729: EOF
2022/11/16 13:41:57 http: TLS handshake error from 127.0.0.1:51866: read tcp 127.0.0.1:51865->127.0.0.1:51866: use of closed network connection
2022/11/16 13:42:01 http2: server: error reading preface from client 127.0.0.1:52677: bogus greeting "CONNECT golang.fake.tld:"

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestResponseControllerSetFutureWriteDeadline"
2022-11-16 13:26 windows-amd64-longtest go@5947a07d net/http.TestResponseControllerSetFutureWriteDeadline (log) 
--- FAIL: TestResponseControllerSetFutureWriteDeadline (0.00s)
    --- FAIL: TestResponseControllerSetFutureWriteDeadline/h1 (0.00s)
        responsecontroller_test.go:146: unexpected connection error: Get "http://127.0.0.1:51242": EOF
2022/11/16 13:41:33 http: TLS handshake error from 127.0.0.1:51729: EOF
2022/11/16 13:41:57 http: TLS handshake error from 127.0.0.1:51866: read tcp 127.0.0.1:51865->127.0.0.1:51866: use of closed network connection
2022/11/16 13:42:01 http2: server: error reading preface from client 127.0.0.1:52677: bogus greeting "CONNECT golang.fake.tld:"

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

Marking as release-blocker because this test is new as of https://go.dev/cl/436890 (attn @neild).

@bcmills bcmills added this to the Go1.20 milestone Nov 17, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/451715 mentions this issue: net/http: deflake TestResponseControllerSetFutureWriteDeadline

@gopherbot gopherbot reopened this Feb 2, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestResponseControllerSetFutureWriteDeadline"
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestResponseControllerSetFutureWriteDeadline (log) 
--- FAIL: TestResponseControllerSetFutureWriteDeadline (0.00s)
2023-02-01 21:30 darwin-amd64-race go@4b7f7eef net/http.TestResponseControllerSetFutureWriteDeadline (log) 
--- FAIL: TestResponseControllerSetFutureWriteDeadline (0.00s)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 2, 2023

The above are #58168.

@bcmills bcmills closed this as completed Feb 2, 2023
@golang golang locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@neild neild

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Test Flakes
Status: Done
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@neild @bcmills @gopherbot