Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/lsprpc: TestEnvForwarding failures #56804

Closed
gopherbot opened this issue Nov 17, 2022 · 4 comments
Closed

x/tools/gopls/internal/lsp/lsprpc: TestEnvForwarding failures #56804

gopherbot opened this issue Nov 17, 2022 · 4 comments
Assignees
@bcmills
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/lsprpc" && test == "TestEnvForwarding"

Issue created automatically to collect these failures.

Example (log):

2022/11/11 14:41:47 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/var/gobuilder/buildlet/tmp/go-build637139245/b455/lsprpc.test"
	client_id="3"
2022/11/11 14:41:47 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:59718->127.0.0.1:59720: use of closed network connection
2022/11/11 14:41:59 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/var/gobuilder/buildlet/tmp/go-build637139245/b455/lsprpc.test"
	client_id="6"
--- FAIL: TestEnvForwarding (30.01s)
    lsprpc_test.go:310: context deadline exceeded
2022/11/11 14:42:29 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:59713->127.0.0.1:59714: use of closed network connection
2022/11/11 14:42:29 ping
2022/11/11 14:42:29 ping
2022/11/11 14:42:30 unable to add local env to initialize request: err: context deadline exceeded: stderr: 
2022/11/11 14:42:30 jsonrpc2 async message delivery failed: io: read/write on closed pipe

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Nov 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/lsprpc" && test == "TestEnvForwarding"
2022-11-11 03:59 netbsd-arm-bsiegert tools@3c3713e6 go@ec651088 x/tools/gopls/internal/lsp/lsprpc.TestEnvForwarding (log) 
2022/11/11 14:41:47 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/var/gobuilder/buildlet/tmp/go-build637139245/b455/lsprpc.test"
	client_id="3"
2022/11/11 14:41:47 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:59718->127.0.0.1:59720: use of closed network connection
2022/11/11 14:41:59 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/var/gobuilder/buildlet/tmp/go-build637139245/b455/lsprpc.test"
	client_id="6"
--- FAIL: TestEnvForwarding (30.01s)
    lsprpc_test.go:310: context deadline exceeded
2022/11/11 14:42:29 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:59713->127.0.0.1:59714: use of closed network connection
2022/11/11 14:42:29 ping
2022/11/11 14:42:29 ping
2022/11/11 14:42:30 unable to add local env to initialize request: err: context deadline exceeded: stderr: 
2022/11/11 14:42:30 jsonrpc2 async message delivery failed: io: read/write on closed pipe

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

This is on a fairly slow builder; I wonder if the arbitrary 30s timeout is just too short?

(@findleyr, do you think it would be reasonable to remove or lengthen the timeout, or perhaps set it based on t.Deadline()?)

@findleyr
Copy link
Contributor

Yes, I think that would be reasonable. That test was written before we understood the implications of arbitrary timeouts on the builders :)

@bcmills bcmills self-assigned this Nov 17, 2022
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Nov 17, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/451599 mentions this issue: gopls/internal/lsp/lsprpc: eliminate arbitrary timeout in TestEnvForwarding

@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2022
@golang golang locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr