Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestPlatformVerifier failures on Windows due to broken connections #56791

Closed
gopherbot opened this issue Nov 17, 2022 · 21 comments
Closed

crypto/x509: TestPlatformVerifier failures on Windows due to broken connections #56791

gopherbot opened this issue Nov 17, 2022 · 21 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows Security
Milestone
Backlog

Comments

@gopherbot
Copy link

gopherbot commented Nov 17, 2022 •
edited by bcmills 

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestPlatformVerifier (41.53s)
    --- FAIL: TestPlatformVerifier/self-signed_leaf (5.03s)
        root_windows_test.go:90: tls connection failed: EOF
    --- FAIL: TestPlatformVerifier/untrusted_root (24.13s)
        root_windows_test.go:90: tls connection failed: tls: first record does not look like a TLS handshake

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test == "TestPlatformVerifier"
2022-11-09 03:01 windows-amd64-longtest go@b4591662 crypto/x509.TestPlatformVerifier (log) 
--- FAIL: TestPlatformVerifier (41.53s)
    --- FAIL: TestPlatformVerifier/self-signed_leaf (5.03s)
        root_windows_test.go:90: tls connection failed: EOF
    --- FAIL: TestPlatformVerifier/untrusted_root (24.13s)
        root_windows_test.go:90: tls connection failed: tls: first record does not look like a TLS handshake
2022-11-15 16:24 windows-amd64-longtest go@6df54215 crypto/x509.TestPlatformVerifier (log) 
--- FAIL: TestPlatformVerifier (45.34s)
    --- FAIL: TestPlatformVerifier/expired_leaf (21.01s)
        root_windows_test.go:90: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
    --- FAIL: TestPlatformVerifier/wrong_host_for_leaf (21.01s)
        root_windows_test.go:90: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@bcmills bcmills changed the title crypto/x509: TestPlatformVerifier failures crypto/x509: TestPlatformVerifier failures on Windows due to broken connections Nov 17, 2022
@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

(attn @golang/windows, @rolandshoemaker; compare #52108)

@bcmills bcmills added this to the Backlog milestone Nov 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test == "TestPlatformVerifier"
2022-11-18 23:57 windows-amd64-longtest go@4f0d3bcd crypto/x509.TestPlatformVerifier (log) 
--- FAIL: TestPlatformVerifier (24.72s)
    --- FAIL: TestPlatformVerifier/expired_leaf (21.01s)
        root_windows_test.go:90: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@rolandshoemaker
Copy link
Member

I think this is probably related to #55050.

@sahnnu
Copy link

sahnnu commented Jun 23, 2023

HOw to handle this issue . Currently i am facing this with go 1.20 on windows 10

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-08-18 17:06 darwin-amd64-longtest go@795e7796 crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (76.37s)
    root_darwin_test.go:103: tls connection failed: dial tcp 142.250.191.238:443: connect: operation timed out
    --- FAIL: TestPlatformVerifierLegacy/expired_leaf_(custom_time) (75.01s)
        testing.go:1490: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-10-09 21:56 windows-amd64-longtest go@5955a03e crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (29.31s)
    --- FAIL: TestPlatformVerifierLegacy/expired_leaf (21.01s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-10-09 22:05 windows-amd64-longtest go@8f61fab6 crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (31.67s)
    --- FAIL: TestPlatformVerifierLegacy/self-signed_leaf (21.02s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
2023-10-09 22:06 windows-amd64-longtest go@51bdd3bd crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (22.28s)
    --- FAIL: TestPlatformVerifierLegacy/expired_leaf (21.03s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-10-09 18:53 darwin-amd64-longtest go@a8ca649b crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (80.15s)
    root_darwin_test.go:103: tls connection failed: dial tcp 104.154.89.105:443: connect: operation timed out
    --- FAIL: TestPlatformVerifierLegacy/self-signed_leaf (75.06s)
        testing.go:1488: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-10-10 16:10 windows-amd64-longtest go@24ae2d92 crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (34.44s)
    --- FAIL: TestPlatformVerifierLegacy/untrusted_root (21.01s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-10-10 16:50 windows-amd64-longtest go@1493dd3c crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (28.05s)
    --- FAIL: TestPlatformVerifierLegacy/untrusted_root (21.02s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-10-10 16:18 windows-amd64-longtest go@e175f27f crypto/x509.TestPlatformVerifier (log) 
--- FAIL: TestPlatformVerifier (28.24s)
    --- FAIL: TestPlatformVerifier/untrusted_root (21.03s)
        root_windows_test.go:90: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
2023-10-10 16:26 windows-amd64-longtest go@8042fd87 crypto/x509.TestPlatformVerifier (log) 
--- FAIL: TestPlatformVerifier (43.69s)
    --- FAIL: TestPlatformVerifier/expired_leaf (21.01s)
        root_windows_test.go:90: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-10-10 18:10 windows-amd64-longtest go@9465990e crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (21.78s)
    --- FAIL: TestPlatformVerifierLegacy/wrong_host_for_leaf (21.02s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@bcmills bcmills mentioned this issue Dec 11, 2023
Open
@gopherbot
Copy link
Author

Change https://go.dev/cl/548976 mentions this issue: crypto/x509: remove TestPlatformVerifierLegacy tests

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-12-11 21:37 windows-amd64-longtest go@c22781cb crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (21.84s)
    --- FAIL: TestPlatformVerifierLegacy/expired_leaf (5.82s)
        root_windows_test.go:102: tls connection failed: EOF

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2023-12-15 18:08 windows-amd64-longtest go@796f59df crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (34.09s)
    --- FAIL: TestPlatformVerifierLegacy/untrusted_root (21.01s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2024-02-17 06:03 windows-amd64-longtest go@86a32d6d crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (63.02s)
    --- FAIL: TestPlatformVerifierLegacy/expired_leaf (21.02s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
    --- FAIL: TestPlatformVerifierLegacy/untrusted_root (21.04s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2024-02-20 06:04 windows-amd64-longtest go@d42cd452 crypto/x509.TestPlatformVerifierLegacy (log) 
--- FAIL: TestPlatformVerifierLegacy (24.93s)
    --- FAIL: TestPlatformVerifierLegacy/expired_leaf (21.01s)
        root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

— watchflakes

@rolandshoemaker
Copy link
Member

Closed the wrong issue 🤦, should have been #65626.

@rolandshoemaker
Copy link
Member

Oh wait, no, this is also Legacy.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test ~ `^TestPlatformVerifier`
2024-02-20 06:04 gotip-windows-amd64-longtest go@d42cd452 crypto/x509.TestPlatformVerifierLegacy/expired_leaf (log) 
=== RUN   TestPlatformVerifierLegacy/expired_leaf
    root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
--- FAIL: TestPlatformVerifierLegacy/expired_leaf (21.51s)
2024-02-20 06:04 gotip-windows-amd64-longtest go@d42cd452 crypto/x509.TestPlatformVerifierLegacy/self-signed_leaf (log) 
=== RUN   TestPlatformVerifierLegacy/self-signed_leaf
    root_windows_test.go:102: tls connection failed: dial tcp 104.154.89.105:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
--- FAIL: TestPlatformVerifierLegacy/self-signed_leaf (21.38s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows Security
Projects
Test Flakes
Status: Done
Milestone
Backlog
Development

No branches or pull requests
4 participants
@rolandshoemaker @bcmills @gopherbot @sahnnu