Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/persistent: TestRandomMap failures #56789

Closed
gopherbot opened this issue Nov 17, 2022 · 2 comments
Closed

x/tools/internal/persistent: TestRandomMap failures #56789

gopherbot opened this issue Nov 17, 2022 · 2 comments
Assignees
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/persistent" && test == "TestRandomMap"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRandomMap (0.21s)
    map_test.go:299: entry is deleted prematurely, key: 1175405730, value: 1175405730

watchflakes

@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Nov 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Nov 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/persistent" && test == "TestRandomMap"
2022-11-07 18:28 openbsd-386-68 tools@50506576 go@e7422b05 x/tools/internal/persistent.TestRandomMap (log)
--- FAIL: TestRandomMap (0.21s)
    map_test.go:299: entry is deleted prematurely, key: 1175405730, value: 1175405730

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

I believe this was fixed in https://go.dev/cl/448696 (CC @findleyr @alandonovan)

@bcmills bcmills closed this as completed Nov 17, 2022
@golang golang locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants