Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: spec violation 6.5.3 #56760

Closed
Duslia opened this issue Nov 16, 2022 · 3 comments
Closed

x/net/http2: spec violation 6.5.3 #56760

Duslia opened this issue Nov 16, 2022 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@Duslia
Copy link

Duslia commented Nov 16, 2022

What version of Go are you using (go version)?

$ go version
1.19

Does this issue reproduce with the latest release?

No

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

I run HTTP2 spec test and there are four tests that cannot be passed.
spec test repo: https://github.com/summerwind/h2spec
command: ./h2spec -p 8888 -k -t -v http2

What did you expect to see?

all the tests passed

What did you see instead?

image

test code:


func main() {
	server := &http.Server{
		Addr:         ":8888",
		ReadTimeout:  5 * time.Second,
		WriteTimeout: 10 * time.Second,
	}

	http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
		w.Write([]byte(fmt.Sprintf("Protocol: %s", r.Proto)))
	})

	if err := server.ListenAndServeTLS("./examples/tls/server.crt", "./examples/tls/server.key"); err != nil {
		log.Fatal(err)
	}
}

@seankhliao
Copy link
Member

4.2 was deemed incorrect: #25023 (comment)
8.1.2.2 is #26321

6.5.3 seems to be a new failure?

cc @neild @tombergan

@seankhliao seankhliao changed the title affected/package: net/http cannot pass spec test x/net/http2: spec violation 6.5.3 Nov 16, 2022
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 16, 2022
@Duslia
Copy link
Author

Duslia commented Nov 18, 2022

4.2 was deemed incorrect: #25023 (comment) 8.1.2.2 is #26321

6.5.3 seems to be a new failure?

cc @neild @tombergan

@seankhliao These pr cause 6.5.3 failure: https://go-review.googlesource.com/c/net/+/124735. It seems that it's expected.

@seankhliao
Copy link
Member

In that case there seems to be nothing new here not tracked in other issues.

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2022
@golang golang locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants