Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: diagnostics not published after workspace folder change #56731

Closed
findleyr opened this issue Nov 14, 2022 · 1 comment
Closed

x/tools/gopls: diagnostics not published after workspace folder change #56731

findleyr opened this issue Nov 14, 2022 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.11.0

Comments

@findleyr
Copy link
Contributor

When workspace folders change dynamically, our mechanism to suppress stale diagnostics prevents new diagnostics from being published for the new workspace layout.
@findleyr findleyr added this to the gopls/v0.10.2 milestone Nov 14, 2022
@findleyr findleyr self-assigned this Nov 14, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 14, 2022
@gopherbot
Copy link

Change https://go.dev/cl/450275 mentions this issue: gopls/internal/lsp: fix diagnostic suppression when folders change

@golang golang locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.11.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr