Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: reenable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV with a different target [1.18 backport] #56711

Closed
gopherbot opened this issue Nov 11, 2022 · 2 comments
Assignees
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@mknyszek requested issue #56708 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport a backport issue for Go 1.18 and Go 1.19 since the same workaround and test skips were applied there.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 11, 2022
@gopherbot gopherbot added this to the Go1.18.9 milestone Nov 11, 2022
@joedian joedian added the CherryPickApproved Used during the release process for point releases label Nov 16, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 16, 2022
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 16, 2022
@neild neild self-assigned this Nov 30, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/454295 mentions this issue: [release-branch.go1.18] net: reenable SRV tests with _ldap._tcp.google.com

@gopherbot gopherbot modified the milestones: Go1.18.9, Go1.18.10 Dec 6, 2022
@gopherbot
Copy link
Author

Closed by merging 11f8a85 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Dec 9, 2022
…e.com

TestLookupDotsWithRemoteSource and TestLookupGoogleSRV
were disabled because they look up the no-longer-present
SRV record for _xmpp-server._tcp.google.com.

Change the tests to look for _ldap._tcp.google.com and
reenable them.

For #56708.
Fixes #56711.

Change-Id: I26475fa3ff6fc008048a4e5f24f0e96ee12f655c
Reviewed-on: https://go-review.googlesource.com/c/go/+/453861
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit cb42bbddeb80ff08599079ee6b94088e5be88e5b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454295
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
@golang golang locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants