Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: reenable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV with a different target #56708

Closed
mknyszek opened this issue Nov 11, 2022 · 7 comments
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@mknyszek
Copy link
Contributor

Due to #56707 these tests were disabled. This issue tracks reenabling them with a different DNS target that works.

CC @neild

@mateusz834
Copy link
Member

We might use now email SRVs like: _submission._tcp.gmail.com

@mknyszek mknyszek added release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Nov 11, 2022
@mknyszek
Copy link
Contributor Author

@gopherbot Please open backport a backport issue for Go 1.18 and Go 1.19 since the same workaround and test skips were applied there.

@gopherbot
Copy link

Backport issue(s) opened: #56711 (for 1.18), #56712 (for 1.19).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 16, 2022
@cherrymui
Copy link
Member

It is not a release blocker, but would be good to be done soon-ish. Thanks.

@neild neild self-assigned this Nov 23, 2022
@gopherbot
Copy link

Change https://go.dev/cl/453861 mentions this issue: net: reenable SRV tests with _ldap._tcp.google.com

@gopherbot
Copy link

Change https://go.dev/cl/454295 mentions this issue: [release-branch.go1.18] net: reenable SRV tests with _ldap._tcp.google.com

@gopherbot
Copy link

Change https://go.dev/cl/454296 mentions this issue: [release-branch.go1.19] net: reenable SRV tests with _ldap._tcp.google.com

gopherbot pushed a commit that referenced this issue Dec 9, 2022
…e.com

TestLookupDotsWithRemoteSource and TestLookupGoogleSRV
were disabled because they look up the no-longer-present
SRV record for _xmpp-server._tcp.google.com.

Change the tests to look for _ldap._tcp.google.com and
reenable them.

For #56708.
Fixes #56712.

Change-Id: I26475fa3ff6fc008048a4e5f24f0e96ee12f655c
Reviewed-on: https://go-review.googlesource.com/c/go/+/453861
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 3b3ab61)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454296
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
gopherbot pushed a commit that referenced this issue Dec 9, 2022
…e.com

TestLookupDotsWithRemoteSource and TestLookupGoogleSRV
were disabled because they look up the no-longer-present
SRV record for _xmpp-server._tcp.google.com.

Change the tests to look for _ldap._tcp.google.com and
reenable them.

For #56708.
Fixes #56711.

Change-Id: I26475fa3ff6fc008048a4e5f24f0e96ee12f655c
Reviewed-on: https://go-review.googlesource.com/c/go/+/453861
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit cb42bbddeb80ff08599079ee6b94088e5be88e5b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454295
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
@golang golang locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

6 participants