Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: link time regression for kubelet at fix transitive inlining of generic functions #56678

Closed
mknyszek opened this issue Nov 9, 2022 · 1 comment
Closed

cmd/link: link time regression for kubelet at fix transitive inlining of generic functions #56678

mknyszek opened this issue Nov 9, 2022 · 1 comment
Assignees
@cherrymui
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.20

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Nov 9, 2022

~2% performance regression that seems to point at 9944ba7.

CC @mdempsky

The benchmark builds cmd/kubelet in the kubernetes main repo at v1.22.1: https://cs.opensource.google/go/x/benchmarks/+/master:sweet/harnesses/go-build.go;l=26
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 9, 2022
@mknyszek mknyszek added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed compiler/runtime Issues related to the Go compiler and/or runtime. labels Nov 9, 2022
@mknyszek mknyszek added this to the Go1.20 milestone Nov 9, 2022
@aclements aclements added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 10, 2023
@cherrymui cherrymui self-assigned this Jan 11, 2023
@cherrymui
Copy link
Member

Tried to run the benchmark locally

name \ time/op                  go1.19      a7538d7      9944ba7           tip
GoBuildKubeletLink          10.4s ± 9%   10.1s ±10%   10.3s ± 3%    10.5s ±14%

(a7538d7 is the commit before 9944ba7)

There is some noise, so it hard to tell.

From the dashboard it seems it no longer regress much at tip now. https://perf.golang.org/dashboard/?benchmark=GoBuildKubeletLink&repository=go&branch=master&days=100&end=2023-01-17T00%3A03
I think we can close this for now.

@golang golang locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cherrymui cherrymui

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
4 participants
@mknyszek @aclements @gopherbot @cherrymui