Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo/testtls: static test fails #56629

Open
aclements opened this issue Nov 7, 2022 · 2 comments
Open

misc/cgo/testtls: static test fails #56629

aclements opened this issue Nov 7, 2022 · 2 comments
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD
Milestone
Backlog

Comments

@aclements
Copy link
Member

What version of Go are you using (go version)?

581a822 in the Go 1.20 development tree

What operating system and processor architecture are you using (go env)?

netbsd/arm, observed on the trybots for CL 448016 PS 2

What did you do?

I've been enabling dist tests for cgo on more architectures where it's not clear why they're disabled. One of the misc/cgo/testtls static build configurations crashes on netbsd/arm (but passes on netbsd/arm64). It's unfortunately not easy to extract tests from dist (something I'm hoping to improve), but I believe this is what the test is doing:

cd $GOROOT/misc/cgo/testtls
go test -short=true -count=1 -run= -ldflags=-linkmode=external -tags=static .

It appears all of the other misc/cgo tests pass once I skip that specific one.

What did you expect to see?

Test passes.

What did you see instead?

Test crashes with SIGABRT. See the trybot log.

/cc @golang/netbsd
@aclements aclements added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 7, 2022
@aclements aclements added this to the Backlog milestone Nov 7, 2022
@aclements aclements added OS-NetBSD arch-arm Issues solely affecting the 32-bit arm architecture. labels Nov 7, 2022
@gopherbot
Copy link

Change https://go.dev/cl/448016 mentions this issue: cmd/dist: add curiously missing GOOS/GOARCH combinations

gopherbot pushed a commit that referenced this issue Nov 16, 2022
@aclements @gopherbot
cmd/dist: add curiously missing GOOS/GOARCH combinations
0266671 
The cmd/dist cgo_test enumerates a large number of platforms in
various special cases. Some combinations are suspiciously absent. This
CL completes the combinations.

I've confirmed using trybots that the newly-enabled tests pass on
android/* (this is not surprising because the gohostos is never
"android" anyway), windows/arm64, linux/ppc64 (no cgo), linux/loong64
(except for one test, filed #56623), linux/mips*, netbsd/arm (except
for one test, filed #56629), and netbsd/arm64. The windows/arm builder
is out to lunch, so I'm assuming that works. Since netbsd/arm and
arm64 mostly passed these tests, I've also enabled them on netbsd/386
and netbsd/amd64, where they seem to work fine as well.

Preparation for #37486.

Change-Id: I04c3348e4f422d74d51e714647ca3db379e6e919
Reviewed-on: https://go-review.googlesource.com/c/go/+/448016
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@qmuntal
Copy link
Contributor

qmuntal commented Nov 17, 2022 •
edited

I've seen a similar failure mode when running misc/cgo/testtls with static linking in our (Microsoft) Go fork CI pipeline. Could be related to #52141, where it was concluded that the failure was due to an old and buggy glibc version installed on the host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@aclements @qmuntal @gopherbot