Skip to content

os/exec: TestPipeLookPathLeak failures #56585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Nov 4, 2022 · 4 comments
Closed

os/exec: TestPipeLookPathLeak failures #56585

gopherbot opened this issue Nov 4, 2022 · 4 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "os/exec" && test == "TestPipeLookPathLeak"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestPipeLookPathLeak (1.00s)
    exec_test.go:656: set of open file descriptors changed: got [0 1 2 3 4 5 6], want [0 1 2 3 4 5 6 7]

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 4, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "os/exec" && test == "TestPipeLookPathLeak"
2022-11-01 22:44 dragonfly-amd64-622 go@81efd7b3 os/exec.TestPipeLookPathLeak (log) 
--- FAIL: TestPipeLookPathLeak (1.00s)
    exec_test.go:656: set of open file descriptors changed: got [0 1 2 3 4 5 6], want [0 1 2 3 4 5 6 7]

— watchflakes

@bcmills bcmills self-assigned this Nov 4, 2022
@bcmills bcmills added this to the Go1.20 milestone Nov 4, 2022
@bcmills
Copy link
Contributor

bcmills commented Nov 4, 2022

Should be fixed by CL 447235.

@bcmills bcmills closed this as completed Nov 4, 2022
@bcmills bcmills moved this to Done in Test Flakes Nov 4, 2022
@golang golang locked and limited conversation to collaborators Nov 4, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "os/exec" && test == "TestPipeLookPathLeak"
2024-05-01 03:56 dragonfly-amd64-622 go@c5698e31 os/exec.TestPipeLookPathLeak (log) 
--- FAIL: TestPipeLookPathLeak (2.00s)
    exec_test.go:702: leaked file descriptor 4

— watchflakes

@gopherbot gopherbot reopened this May 1, 2024
@dmitshur
Copy link
Contributor

That looks like a different failure mode. I'll re-close this frozen issue and take it out of Test Flakes so that watchflakes can create a new issue.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 30, 2024
@dmitshur dmitshur removed this from Test Flakes May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot