Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: TestDisasm failures #56574

Open
gopherbot opened this issue Nov 4, 2022 · 13 comments
Open

cmd/pprof: TestDisasm failures #56574

gopherbot opened this issue Nov 4, 2022 · 13 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Linux
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "cmd/pprof" && test == "TestDisasm"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestDisasm (1.41s)
    pprof_test.go:118: pprof failed: exit status 2
        no matches found for regexp: main.main

watchflakes

@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Nov 4, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/pprof" && test == "TestDisasm"
2022-10-24 16:31 linux-arm64 go@65f86352 cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.41s)
    pprof_test.go:118: pprof failed: exit status 2
        no matches found for regexp: main.main
2022-11-03 19:34 linux-arm64 go@3511c822 cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.42s)
    pprof_test.go:118: pprof failed: exit status 2
        no matches found for regexp: main.main
2022-11-04 14:19 linux-arm64 go@7ddbadb3 cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.41s)
    pprof_test.go:118: pprof failed: exit status 2
        no matches found for regexp: main.main

watchflakes

@cherrymui cherrymui self-assigned this Nov 7, 2022
@cherrymui
Copy link
Member

This seems on the new linux-arm64 builder (#53851). @cagedmantis do you think the new builder is stable and reliable, or there is still some issue? Thanks.

@cagedmantis
Copy link
Contributor

@cherrymui The builder should be stable and reliable enough where any issue should be investigated.

@mknyszek mknyszek added this to the Go1.20 milestone Nov 9, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/450281 mentions this issue: cmd/pprof: debug TestDisasm

gopherbot pushed a commit that referenced this issue Nov 15, 2022
If pprof -disasm fails, print the profile content for debugging.

For #56574.

Change-Id: I5d9377b7fb80f6b85317bc53f3ebb18f70c2f06d
Reviewed-on: https://go-review.googlesource.com/c/go/+/450281
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/pprof" && test == "TestDisasm"
2022-11-15 00:02 linux-arm64 go@e6ebbefa cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.41s)
    pprof_test.go:118: pprof failed: exit status 2
        no matches found for regexp: main.main

watchflakes

@cherrymui
Copy link
Member

Unfortunately the failure on 11-15 is still before my debugging CL landed. We'll see if we can get some information if a new failure occurs.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/pprof" && test == "TestDisasm"
2022-11-17 17:24 linux-arm64 go@5c834a2e cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.43s)
    pprof_test.go:110: pprof -disasm failed: exit status 2
        no matches found for regexp: main.main
    pprof_test.go:118: profile content:
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2022-11-17 17:34:46.01668506 +0000 UTC
        Duration: 1.10
        Samples:
        samples/count cpu/nanoseconds
                 97  970000000: 1 
                  1   10000000: 2 
        Locations
             1: 0x6fa94 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:377 s=311
             2: 0x6fa98 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:378 s=311
        Mappings
        1: 0x10000/0xb8000/0x0 /tmp/workdir/tmp/TestDisasm2297534319/001/cpu.exe  [FN]
2022-11-17 21:15 linux-arm64 go@1f4394a0 cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.50s)
    pprof_test.go:110: pprof -disasm failed: exit status 2
        no matches found for regexp: main.main
    pprof_test.go:118: profile content:
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2022-11-17 21:25:17.962118619 +0000 UTC
        Duration: 1.10
        Samples:
        samples/count cpu/nanoseconds
                 93  930000000: 1 
                  2   20000000: 2 
                  1   10000000: 3 
                  1   10000000: 4 
                  1   10000000: 5 
        Locations
             1: 0x6fa94 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:377 s=311
             2: 0x6fa98 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:378 s=311
             3: 0x6fa30 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:333 s=311
             4: 0x6fa08 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:320 s=311
             5: 0x6fa28 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:330 s=311
        Mappings
        1: 0x10000/0xb8000/0x0 /tmp/workdir/tmp/TestDisasm4084982061/001/cpu.exe  [FN]

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/pprof" && test == "TestDisasm"
2022-11-18 17:59 linux-arm64 go@b2faff18 cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.42s)
    pprof_test.go:110: pprof -disasm failed: exit status 2
        no matches found for regexp: main.main
    pprof_test.go:118: profile content:
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2022-11-18 18:09:26.035842499 +0000 UTC
        Duration: 1.10
        Samples:
        samples/count cpu/nanoseconds
                 94  940000000: 1 
                  1   10000000: 2 
                  1   10000000: 3 
                  2   20000000: 4 
                  1   10000000: 5 
                  1   10000000: 6 
        Locations
             1: 0x6f974 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:377 s=311
             2: 0x6f8d8 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:311 s=311
             3: 0x6f984 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:387 s=311
             4: 0x6f978 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:378 s=311
             5: 0x6f8ec M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:321 s=311
             6: 0x6f8e8 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:320 s=311
        Mappings
        1: 0x10000/0xb8000/0x0 /tmp/workdir/tmp/TestDisasm2137471865/001/cpu.exe  [FN]

watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/455166 mentions this issue: runtime: prioritize VDSO and libcall unwinding in profiler

@gopherbot gopherbot reopened this Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/pprof" && test == "TestDisasm"
2022-11-10 18:45 linux-arm64 go@531ba0c8 cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.44s)
    pprof_test.go:118: pprof failed: exit status 2
        no matches found for regexp: main.main
2022-11-15 20:17 linux-arm64 go@9754bc7b cmd/pprof.TestDisasm (log)
--- FAIL: TestDisasm (1.40s)
    pprof_test.go:118: pprof -disasm failed: exit status 2
        no matches found for regexp: main.main
    pprof_test.go:126: profile content:
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2022-11-15 20:27:39.220352422 +0000 UTC
        Duration: 1.10
        Samples:
        samples/count cpu/nanoseconds
                 97  970000000: 1 
                  1   10000000: 2 
                  1   10000000: 3 
                  1   10000000: 4 
        Locations
             1: 0x6fa84 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:377 s=311
             2: 0x6f9fc M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:321 s=311
             3: 0x6fa88 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:378 s=311
             4: 0x6fa20 M=1 runtime.nanotime1 /tmp/workdir/go/src/runtime/sys_linux_arm64.s:333 s=311
        Mappings
        1: 0x10000/0xba000/0x0 /tmp/workdir/tmp/TestDisasm2593135869/001/cpu.exe  [FN]

watchflakes

@cherrymui
Copy link
Member

The failures are before the fix.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. OS-Linux and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 19, 2023
@gopherbot gopherbot reopened this Apr 18, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/pprof" && test == "TestDisasm"
2024-04-03 15:35 go1.21-openbsd-amd64 release-branch.go1.21@d8392e69 cmd/pprof.TestDisasm (log)
=== RUN   TestDisasm
    pprof_test.go:112: pprof -disasm failed: exit status 2
        no matches found for regexp: main.main
    pprof_test.go:120: profile content:
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2024-04-03 08:53:45.525865952 -0700 PDT
        Duration: 2.44
        Samples:
        samples/count cpu/nanoseconds
                  1   10000000: 1 2 3 4 5 6 
        Locations
             1: 0x44e52d M=1 runtime.kevent /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/sys_openbsd2.go:219 s=218
             2: 0x42dd1a M=1 runtime.netpoll /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/netpoll_kqueue.go:141 s=121
             3: 0x438bf1 M=1 runtime.findRunnable /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/proc.go:3186 s=2886
             4: 0x439d50 M=1 runtime.schedule /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/proc.go:3577 s=3548
             5: 0x43a25e M=1 runtime.park_m /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/proc.go:3740 s=3716
             6: 0x45c78d M=1 runtime.mcall /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/asm_amd64.s:458 s=428
        Mappings
        1: 0x0/0x0/0x0 /home/swarming/.swarming/w/ir/x/t/TestDisasm2561604156/001/cpu.exe  [FN]
--- FAIL: TestDisasm (23.03s)
2024-04-10 20:23 gotip-openbsd-amd64 go@c23579f0 cmd/pprof.TestDisasm (log)
=== RUN   TestDisasm
    pprof_test.go:111: pprof -disasm failed: exit status 2
        no matches found for regexp main.main
    pprof_test.go:119: profile content:
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2024-04-10 13:40:34.632853971 -0700 PDT
        Duration: 1.00
        Samples:
        samples/count cpu/nanoseconds
        Locations
        Mappings
        1: 0x0/0x0/0x0 /home/swarming/.swarming/w/ir/x/t/TestDisasm2990457179/001/cpu.exe  
--- FAIL: TestDisasm (18.24s)
2024-04-18 15:39 gotip-openbsd-amd64 go@84fbdf01 cmd/pprof.TestDisasm (log)
=== RUN   TestDisasm
    pprof_test.go:111: pprof -disasm failed: exit status 2
        no matches found for regexp main.main
    pprof_test.go:119: profile content:
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2024-04-18 08:57:54.068820717 -0700 PDT
        Duration: 1.12
        Samples:
        samples/count cpu/nanoseconds
        Locations
        Mappings
        1: 0x0/0x0/0x0 /home/swarming/.swarming/w/ir/x/t/TestDisasm808078515/001/cpu.exe  
--- FAIL: TestDisasm (21.20s)

watchflakes

@mknyszek
Copy link
Contributor

CC @golang/openbsd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Linux
Projects
Status: Done
Development

No branches or pull requests

5 participants