Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: support for RDPID instruction #56525

Closed
piotr-sneller opened this issue Nov 2, 2022 · 1 comment
Closed

cmd/asm: support for RDPID instruction #56525

piotr-sneller opened this issue Nov 2, 2022 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@piotr-sneller
Copy link

What version of Go are you using (go version)?

go1.19.2 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Windows 10/x64

Details

The following code shows the RDPID instruction is not recognized by the assembler.

TEXT getCoreID_RDPID(SB), NOSPLIT | NOFRAME, $0-0
    RDPIDQ   AX
    RET

While it is simple enough to work around the problem with the BYTE directive, RDPID is a valid x64 instruction and the assembler should know about it.

What did you expect to see?

Flawless compilation.

What did you see instead?

test.s:35: unrecognized instruction "RDPIDQ"
asm: assembly of test.s failed
@randall77 randall77 added this to the Unplanned milestone Nov 2, 2022
@seankhliao seankhliao changed the title go/assembler cmd/asm: support for RDPID instruction Nov 2, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 2, 2022
@mdempsky mdempsky added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 3, 2022
@gopherbot
Copy link

Change https://go.dev/cl/482955 mentions this issue: cmd/asm,cmd/internal/obj/x86: add RDPID instruction to x86 assembler

@golang golang locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@mdempsky @randall77 @gopherbot @cherrymui @piotr-sneller and others