Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: update subrepo list #56482

Closed
seankhliao opened this issue Oct 29, 2022 · 7 comments
Closed

x/pkgsite: update subrepo list #56482

seankhliao opened this issue Oct 29, 2022 · 7 comments
Assignees
@findleyr
Labels
FrozenDueToAge pkgsite
Milestone
pkgsite/backlog

Comments

@seankhliao
Copy link
Member

What is the URL of the page with the issue?

https://pkg.go.dev/golang.org/x

Currently the sub repo page lists the following repos

benchmarks — benchmarks to measure Go as it is developed.
blog — blog.golang.org's implementation.
build — build.golang.org's implementation.
crypto — additional cryptography packages.
debug — an experimental debugger for Go.
image — additional imaging packages.
mobile — experimental support for Go on mobile platforms.
net — additional networking packages.
perf — packages and tools for performance measurement, storage, and analysis.
pkgsite — home of the pkg.go.dev website.
review — a tool for working with Gerrit code reviews.
sync — additional concurrency primitives.
sys — packages for making system calls.
text — packages for working with text.
time — additional time packages.
tools — godoc, goimports, gorename, and other tools.
tour — tour.golang.org's implementation.
exp — experimental and deprecated packages (handle with care; may change without warning).

"blog" should be removed, the repo has been cleared out
"mod", "oauth2", "term", and "vuln" seem to be suitable candidates for adding to the list
"exp" could be moved up to follow alphabetical order?

Could a link to this page be added to the footer under Packages / Standard library?
@gopherbot gopherbot added this to the Unreleased milestone Oct 29, 2022
@findleyr findleyr modified the milestones: Unreleased, pkgsite/later Nov 1, 2022
@findleyr
Copy link
Contributor

findleyr commented Nov 1, 2022

Suggested changes make sense to me. Not sure whether oauth2 and term were intentionally omitted, since they have existed for some time. mod and vuln are new enough that I suspect they just post-dated the original list.

CC @jamalc, who appears to have some context on this page.

@jamalc
Copy link

jamalc commented Nov 2, 2022

We should make this page more accessible, a link could fit nicely in the new navbar and the footer. I believe we copied the list from godoc for #47281. #37265 mentions that the list was intentionally not exhaustive but I'm not sure what is the threshold for noteworthy.

@findleyr findleyr self-assigned this Nov 3, 2022
@seankhliao seankhliao mentioned this issue Mar 6, 2023
Closed
@AGWA
Copy link

AGWA commented Mar 6, 2023

If the list is intentionally not exhaustive, I would suggest noting this on the page. I ended up reinventing the wheel on some modules-related stuff because I didn't know that golang.org/x/mod existed; I would have looked harder if I knew the list wasn't exhaustive.

@gopherbot
Copy link

Change https://go.dev/cl/476202 mentions this issue: static/frontend/subrepo: update subrepo list

gopherbot pushed a commit to golang/pkgsite that referenced this issue Mar 15, 2023
@findleyr
static/frontend/subrepo: update subrepo list
57ea99b 
This CL includes several changes related to the sub-repositories page:
- remove x/blog, which has been cleared out
- add x/mod, x/oauth2, x/term, x/vuln, and x/website
- sort x/exp alphabetically, as others; no need for it to be an outlier
- note that the list is not exhaustive, and redirect to
  go.googlesource.com for the full list
- remove stale suggestion to use `go get`; this is unnecessary, and
  wrong for installing binaries
- add a footer link to the sub-repositories page

Updates golang/go#56482

Change-Id: I87e7df911ba692c15e99ab9b28c66e63e32e0073
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/476202
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@findleyr
Copy link
Contributor

It took me a while to get to this, sorry.

I've made most of the recommended changes here. I also included x/website in the list.

@jamalc you mentioned making this page more accessible. It seemed OK to me, though I didn't try it out with a screen reader. Can we close this issue and handle accessibility more holistically in a separate issue? (I think we have plans to do a more widespread accessibility analysis)

@jamalc
Copy link

jamalc commented Mar 15, 2023

Yes, I meant "easy to be reached" and we will address web accessibility more holistically later this year.

@findleyr
Copy link
Contributor

"easy to be reached"

Oh. That makes sense now that I re-read your comment!

Ok, then I'll close this now.

@golang golang locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
5 participants
@AGWA @gopherbot @seankhliao @jamalc @findleyr