Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportKeepAlives failures #56419

Closed
gopherbot opened this issue Oct 25, 2022 · 14 comments
Closed

net/http: TestTransportKeepAlives failures #56419

gopherbot opened this issue Oct 25, 2022 · 14 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"

Issue created automatically to collect these failures.

Example (log):

2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59308: EOF
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59304: EOF
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59307: read tcp 127.0.0.1:59309->127.0.0.1:59307: read: connection reset by peer
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59303: read tcp 127.0.0.1:59309->127.0.0.1:59303: read: connection reset by peer
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59300: EOF
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.08s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:59146, *net.TCPConn 0x4000310b80"; body2="127.0.0.1:59143, *net.TCPConn 0x4000010820"
2022/10/23 09:58:47 http: TLS handshake error from 127.0.0.1:59139: write tcp 127.0.0.1:59140->127.0.0.1:59139: i/o timeout
2022/10/23 09:58:47 http: TLS handshake error from 127.0.0.1:59136: write tcp 127.0.0.1:59137->127.0.0.1:59136: i/o timeout
2022/10/23 09:58:47 http: TLS handshake error from 127.0.0.1:59130: write tcp 127.0.0.1:59131->127.0.0.1:59130: i/o timeout
2022/10/23 09:58:55 http: TLS handshake error from 127.0.0.1:58892: EOF
2022/10/23 09:58:55 http: TLS handshake error from 127.0.0.1:58885: EOF
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58859: read tcp 127.0.0.1:58862->127.0.0.1:58859: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58857: read tcp 127.0.0.1:58862->127.0.0.1:58857: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58855: read tcp 127.0.0.1:58862->127.0.0.1:58855: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58852: read tcp 127.0.0.1:58862->127.0.0.1:58852: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58858: write tcp 127.0.0.1:58862->127.0.0.1:58858: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58853: write tcp 127.0.0.1:58862->127.0.0.1:58853: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58839: read tcp 127.0.0.1:58843->127.0.0.1:58839: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58838: read tcp 127.0.0.1:58843->127.0.0.1:58838: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58835: read tcp 127.0.0.1:58843->127.0.0.1:58835: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58836: read tcp 127.0.0.1:58843->127.0.0.1:58836: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58834: read tcp 127.0.0.1:58843->127.0.0.1:58834: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58837: write tcp 127.0.0.1:58843->127.0.0.1:58837: use of closed network connection
2022/10/23 09:59:00 http2: server: error reading preface from client 127.0.0.1:58725: bogus greeting "CONNECT golang.fake.tld:"
2022/10/23 09:59:00 http2: server: error reading preface from client 127.0.0.1:58723: bogus greeting "CONNECT golang.fake.tld:"

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 25, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2022-10-18 20:53 netbsd-arm64-bsiegert go@a8e4b8c2 net/http.TestTransportKeepAlives (log) 
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59308: EOF
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59304: EOF
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59307: read tcp 127.0.0.1:59309->127.0.0.1:59307: read: connection reset by peer
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59303: read tcp 127.0.0.1:59309->127.0.0.1:59303: read: connection reset by peer
2022/10/23 09:58:41 http: TLS handshake error from 127.0.0.1:59300: EOF
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.08s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:59146, *net.TCPConn 0x4000310b80"; body2="127.0.0.1:59143, *net.TCPConn 0x4000010820"
2022/10/23 09:58:47 http: TLS handshake error from 127.0.0.1:59139: write tcp 127.0.0.1:59140->127.0.0.1:59139: i/o timeout
2022/10/23 09:58:47 http: TLS handshake error from 127.0.0.1:59136: write tcp 127.0.0.1:59137->127.0.0.1:59136: i/o timeout
2022/10/23 09:58:47 http: TLS handshake error from 127.0.0.1:59130: write tcp 127.0.0.1:59131->127.0.0.1:59130: i/o timeout
2022/10/23 09:58:55 http: TLS handshake error from 127.0.0.1:58892: EOF
2022/10/23 09:58:55 http: TLS handshake error from 127.0.0.1:58885: EOF
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58859: read tcp 127.0.0.1:58862->127.0.0.1:58859: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58857: read tcp 127.0.0.1:58862->127.0.0.1:58857: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58855: read tcp 127.0.0.1:58862->127.0.0.1:58855: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58852: read tcp 127.0.0.1:58862->127.0.0.1:58852: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58858: write tcp 127.0.0.1:58862->127.0.0.1:58858: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58853: write tcp 127.0.0.1:58862->127.0.0.1:58853: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58839: read tcp 127.0.0.1:58843->127.0.0.1:58839: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58838: read tcp 127.0.0.1:58843->127.0.0.1:58838: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58835: read tcp 127.0.0.1:58843->127.0.0.1:58835: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58836: read tcp 127.0.0.1:58843->127.0.0.1:58836: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58834: read tcp 127.0.0.1:58843->127.0.0.1:58834: use of closed network connection
2022/10/23 09:58:58 http: TLS handshake error from 127.0.0.1:58837: write tcp 127.0.0.1:58843->127.0.0.1:58837: use of closed network connection
2022/10/23 09:59:00 http2: server: error reading preface from client 127.0.0.1:58725: bogus greeting "CONNECT golang.fake.tld:"
2022/10/23 09:59:00 http2: server: error reading preface from client 127.0.0.1:58723: bogus greeting "CONNECT golang.fake.tld:"

— watchflakes

@bcmills bcmills mentioned this issue Oct 25, 2022
Closed
@bcmills
Copy link
Contributor

bcmills commented Oct 25, 2022 •
edited

This looks like the same failure mode reported on solaris-amd64-oraclerel in #35159. (Keeping this issue instead because it already has a watchflakes pattern configured.)

Since there are no common elements between netbsd/arm64 and solaris/amd64, this looks to me like a platform-independent net/http bug (attn @neild).

@bcmills bcmills added this to the Backlog milestone Oct 25, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2022-12-05 19:25 freebsd-arm-paulzhol go@b45cb0ce net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (1.38s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:33264, *net.TCPConn 0x29e18868"; body2="127.0.0.1:33265, *net.TCPConn 0x29924010"

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2022-12-22 15:23 darwin-amd64-race go@6d3139b2 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.12s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:53651, *net.TCPConn 0xc000012370"; body2="127.0.0.1:53654, *net.TCPConn 0xc000012420"

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-01-09 15:34 freebsd-arm-paulzhol go@841c3eb1 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.06s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:54272, *net.TCPConn 0x29a66a88"; body2="127.0.0.1:54273, *net.TCPConn 0x2995dce0"

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-01-18 15:34 windows-amd64-race go@2e792a82 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.10s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:50958, *net.TCPConn 0xc00000a1a0"; body2="127.0.0.1:50967, *net.TCPConn 0xc0006d6000"
2023-01-19 20:46 darwin-amd64-nocgo go@e08642ca net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.07s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:50384, *net.TCPConn 0xc0004fc000"; body2="127.0.0.1:50400, *net.TCPConn 0xc00051a3a0"

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-01-27 17:13 darwin-amd64-12_0 go@c8c646d3 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.11s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:50391, *net.TCPConn 0xc000221ea8"; body2="127.0.0.1:50400, *net.TCPConn 0xc000221ec8"
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
2023-02-01 21:30 darwin-amd64-race go@4b7f7eef net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 2, 2023

Two of #58168 and one real hit for this issue.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-03-10 21:27 freebsd-arm-paulzhol go@53c91f92 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.07s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:25927, *net.TCPConn 0x29dc4ae8"; body2="127.0.0.1:25928, *net.TCPConn 0x29ae5a10"

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-03-14 04:30 darwin-amd64-race go@7ec69abf net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.09s)
        transport_test.go:191: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:53168, *net.TCPConn 0xc001b88428"; body2="127.0.0.1:53172, *net.TCPConn 0xc000310658"

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-03-28 14:28 netbsd-arm-bsiegert go@abf9b112 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.17s)
        transport_test.go:193: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:63808, *net.TCPConn 0x10828f0"; body2="127.0.0.1:63807, *net.TCPConn 0x1100930"

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-04-06 17:48 darwin-amd64-10_15 go@be50055e net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.09s)
        transport_test.go:193: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:50776, *net.TCPConn 0xc000384658"; body2="127.0.0.1:50783, *net.TCPConn 0xc0003846b8"

— watchflakes

@bcmills bcmills mentioned this issue Apr 7, 2023
Closed
@gopherbot
Copy link
Author

Change https://go.dev/cl/483116 mentions this issue: net/http: wait forever for write results in tests

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportKeepAlives"
2023-04-07 16:45 openbsd-arm64-jsing go@38dadcc3 net/http.TestTransportKeepAlives (log) 
--- FAIL: TestTransportKeepAlives (0.00s)
    --- FAIL: TestTransportKeepAlives/h1 (0.19s)
        transport_test.go:193: error in disableKeepAlive=false. unexpected bodiesDiffer=true; body1="127.0.0.1:6340, *net.TCPConn 0x4000196588"; body2="127.0.0.1:12520, *net.TCPConn 0x400028a708"

— watchflakes

@dmitshur dmitshur modified the milestones: Backlog, Go1.21 May 24, 2023
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot and others