Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: on linux/PPC64, usleep computes incorrect tv_nsec parameter [1.19 backport] #56397

Closed
gopherbot opened this issue Oct 24, 2022 · 2 comments
Closed

runtime: on linux/PPC64, usleep computes incorrect tv_nsec parameter [1.19 backport] #56397

gopherbot opened this issue Oct 24, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.4

Comments

@gopherbot
Copy link
Contributor

@pmur requested issue #56374 to be considered for backport to the next 1.19 minor release.

@gopherbot please consider a backport to 1.18 and 1.19. This is a subtle bug.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 24, 2022
@gopherbot gopherbot mentioned this issue Oct 24, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 24, 2022
@gopherbot gopherbot added this to the Go1.19.3 milestone Oct 24, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/445157 mentions this issue: [release-branch.go1.19] runtime: fix usleep on linux/PPC64

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Oct 26, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 26, 2022
@gopherbot gopherbot modified the milestones: Go1.19.3, Go1.19.4 Nov 1, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 23fd10b to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Nov 8, 2022
@pmur @mknyszek
[release-branch.go1.19] runtime: fix usleep on linux/PPC64
23fd10b 
The existing implementation fails to convert the remainder
microseconds to nanoseconds. This causes sysmon to consume
much more cpu, and generate lots of context switches.

We can also do a little better here to avoid division by a
constant. I used go to determine the magic numbers.

Fixes #56397

Change-Id: I2e37ec218b9027efab6db4634eed1504c0c1b3c8
Reviewed-on: https://go-review.googlesource.com/c/go/+/444735
Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/445157
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@pmur @andrew-d
[release-branch.go1.19] runtime: fix usleep on linux/PPC64
a78f040 
The existing implementation fails to convert the remainder
microseconds to nanoseconds. This causes sysmon to consume
much more cpu, and generate lots of context switches.

We can also do a little better here to avoid division by a
constant. I used go to determine the magic numbers.

Fixes golang#56397

Change-Id: I2e37ec218b9027efab6db4634eed1504c0c1b3c8
Reviewed-on: https://go-review.googlesource.com/c/go/+/444735
Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/445157
@golang golang locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.4
Development

No branches or pull requests
2 participants
@gopherbot @heschi