Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: mail requires -trust=false #56343

Closed
johanbrandhorst opened this issue Oct 20, 2022 · 5 comments
Closed

x/review/git-codereview: mail requires -trust=false #56343

johanbrandhorst opened this issue Oct 20, 2022 · 5 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@johanbrandhorst
Copy link
Member

What version of Go are you using (go version)?

$ go version
go version go1.19.2 linux/amd64

Does this issue reproduce with the latest release?

Yes, I ran go install golang.org/x/review/git-codereview@latest

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/johan/.cache/go-build"
GOENV="/home/johan/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/johan/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/johan/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/nix/store/8s8mxpa681mbddak431k8nxg1ib5pw0g-go-1.19.2/share/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/nix/store/8s8mxpa681mbddak431k8nxg1ib5pw0g-go-1.19.2/share/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19.2"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1025149787=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I was following the contribution guide (https://go.dev/doc/contribute), and after running git mail to submit a change I got an unexpected error.

What did you expect to see?

I expected for git mail to create a CL with my changes.

What did you see instead?

$ git mail
remote: Processing changes: refs: 1, done    
To https://go.googlesource.com/go
 ! [remote rejected]       HEAD -> refs/for/master%l=Trust (label "Trust" is not a configured label)
error: failed to push some refs to 'https://go.googlesource.com/go'
(running: git push -q origin HEAD:refs/for/master%l=Trust)
git-codereview: exit status 1

Running git mail -trust=false fixes the issue, but I don't understand why this is required. Nothing in the contribution guide mentions this flag.
@gopherbot gopherbot added this to the Unreleased milestone Oct 20, 2022
@cuonglm
Copy link
Member

cuonglm commented Oct 20, 2022

-trust is not used anymore: golang/review@f2105c4

Sounds like you want @master instead of @latest.

@mvdan
Copy link
Member

mvdan commented Oct 20, 2022

Given that the majority of people will default to using "latest", perhaps we can aim to regularly tag x/review. Especially when breaking changes like these are made. cc @golang/release

@mvdan
Copy link
Member

mvdan commented Oct 20, 2022

On second thought, the latest commit is already tagged. So I guess we already do this. I'm confused.

@dmitshur
Copy link
Contributor

The -trust flag is obsolete and was removed in CL 399117, which is included in v1.1.0. Maybe the git-codereview binary you installed with go install golang.org/x/review/git-codereview@latest isn't in your PATH? What's the output go version -m $(which git-codereview)?

@dmitshur dmitshur added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 20, 2022
@johanbrandhorst
Copy link
Member Author

The -trust flag is obsolete and was removed in CL 399117, which is included in v1.1.0. Maybe the git-codereview binary you installed with go install golang.org/x/review/git-codereview@latest isn't in your PATH? What's the output go version -m $(which git-codereview)?

Oops, this does seem to be what happened here, thanks for the tip! False alarm 😄.

@golang golang locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dmitshur @mvdan @cuonglm @johanbrandhorst @gopherbot