Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto: tag v1.0.0 #56325

Open
FiloSottile opened this issue Oct 19, 2022 · 1 comment
Open

x/crypto: tag v1.0.0 #56325

FiloSottile opened this issue Oct 19, 2022 · 1 comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@FiloSottile
Copy link
Contributor

x/ repo tagging is here!

@heschi mentioned in #48523 that the system supports v1 as well, and I think that's a better fit for x/crypto than v0. The API is absolutely full of things I wish were not there, but it's been around for too long, and I don't think it would be tenable to make any backwards-incompatible changes without bumping the import path (which going from v0 to v1 doesn't do).

In practice, we've been upholding the Go Compatibility Promise in x/crypto for years, so we're effectively already at v1, we just need to call it that.

/cc @golang/security

@gopherbot gopherbot added this to the Unreleased milestone Oct 19, 2022
@heschi heschi added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 24, 2022
@qmuntal
Copy link
Contributor

qmuntal commented Aug 16, 2023

I've spent a good amount of time investigating if golang.org/x/crypto could suffer backwards-incompatible changes or not, till I found this issue.

Bumping it to v1 would help communicate that it holds higher compatibility standards than other golang.org/x modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

4 participants