x/tools/gopls: panic during renaming for package using unsafe.Slice #56227
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Reported by @jba: gopls panics here on a package using unsafe.Slice, because the coreType of the
call.Fun
istypes.Typ[types.Invalid]
, not a*types.Signature
.Repro:
Checkout x/exp at 4de253d81 (or probably just master), open the slog module, and try to rename almost anything (for example, I tried renaming
logger.Enabled
).We can work around this, but superficially it looks like this may be a go/types bug. I believe that the invalid type is ultimately coming from type-checking, and this is a well-typed package. types.Type[types.Invalid] should not be reachable.
Currently investigating.
CC @adonovan @griesemer
The text was updated successfully, but these errors were encountered: