Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/internal/checker: TestRunDespiteErrors failures #56203

Closed
gopherbot opened this issue Oct 13, 2022 · 2 comments
Closed

x/tools/go/analysis/internal/checker: TestRunDespiteErrors failures #56203

gopherbot opened this issue Oct 13, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/internal/checker" && test == "TestRunDespiteErrors"

Issue created automatically to collect these failures.

Example (log):

/tmp/workdir/tmp/analysistest3759492721/src/rename/test.go:4:2: renaming "bar" to "baz"
/tmp/workdir/tmp/analysistest3759492721/src/rename/test.go:5:6: renaming "bar" to "baz"
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
rename: analysis skipped due to errors in package
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
rename: analysis skipped due to errors in package
-: package xyz is not in GOROOT (/tmp/workdir/go/src/xyz)
2022/10/10 10:32:04 error during loading
-: package abc is not in GOROOT (/tmp/workdir/go/src/abc)
2022/10/10 10:32:04 error during loading
-: package xyz is not in GOROOT (/tmp/workdir/go/src/xyz)
-: package abc is not in GOROOT (/tmp/workdir/go/src/abc)
2022/10/10 10:32:04 2 errors during loading
-: package xyz is not in GOROOT (/tmp/workdir/go/src/xyz)
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
2022/10/10 10:32:05 2 errors during loading
2022/10/10 10:32:06 file=non/existing/dir matched no packages
2022/10/10 10:32:07 sort matched no packages
--- FAIL: TestRunDespiteErrors (15.98s)
    checker_test.go:154: got incorrect exit code 1 for test no-errors; want 0
/tmp/workdir/tmp/analysistest3090848665/src/comment/doc.go:1:1:

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 13, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/internal/checker" && test == "TestRunDespiteErrors"
2022-10-10 17:23 openbsd-amd64-68 tools@19cfa797 go@89566448 x/tools/go/analysis/internal/checker.TestRunDespiteErrors (log) 
/tmp/workdir/tmp/analysistest3759492721/src/rename/test.go:4:2: renaming "bar" to "baz"
/tmp/workdir/tmp/analysistest3759492721/src/rename/test.go:5:6: renaming "bar" to "baz"
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
rename: analysis skipped due to errors in package
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
rename: analysis skipped due to errors in package
-: package xyz is not in GOROOT (/tmp/workdir/go/src/xyz)
2022/10/10 10:32:04 error during loading
-: package abc is not in GOROOT (/tmp/workdir/go/src/abc)
2022/10/10 10:32:04 error during loading
-: package xyz is not in GOROOT (/tmp/workdir/go/src/xyz)
-: package abc is not in GOROOT (/tmp/workdir/go/src/abc)
2022/10/10 10:32:04 2 errors during loading
-: package xyz is not in GOROOT (/tmp/workdir/go/src/xyz)
/tmp/workdir/tmp/analysistest1503881322/src/rderr/test.go:5:9: invalid operation: s + 1 (mismatched types string and untyped int)
2022/10/10 10:32:05 2 errors during loading
2022/10/10 10:32:06 file=non/existing/dir matched no packages
2022/10/10 10:32:07 sort matched no packages
--- FAIL: TestRunDespiteErrors (15.98s)
    checker_test.go:154: got incorrect exit code 1 for test no-errors; want 0
/tmp/workdir/tmp/analysistest3090848665/src/comment/doc.go:1:1:

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Oct 13, 2022
@gopherbot gopherbot added this to the Unreleased milestone Oct 13, 2022
@adonovan
Copy link
Member

I believe this was fixed by CL 443099 and related work.

@golang golang locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@adonovan @gopherbot