Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/coverage: TestIssue56006EmitDataRaceCoverRunningGoroutine failures #56195

Closed
gopherbot opened this issue Oct 13, 2022 · 3 comments
Closed

runtime/coverage: TestIssue56006EmitDataRaceCoverRunningGoroutine failures #56195

gopherbot opened this issue Oct 13, 2022 · 3 comments
Assignees
@thanm
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.20

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "runtime/coverage" && test == "TestIssue56006EmitDataRaceCoverRunningGoroutine"

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 3m0s

syscall.Syscall6(0x119, 0x1, 0x2750c, 0xc00009bc98, 0x1000004, 0x0, 0x0)
	/data/golang/workdir/go/src/syscall/syscall_linux.go:90 +0x18 fp=0xc00009bc40 sp=0xc00009bbd0 pc=0x99198
os.(*Process).blockUntilWaitable(0xc0001ba270)
	/data/golang/workdir/go/src/os/wait_waitid.go:32 +0x6e fp=0xc00009bd30 sp=0xc00009bc40 pc=0xb9e3e
os.(*Process).wait(0xc0001ba270)
	/data/golang/workdir/go/src/os/exec_unix.go:22 +0x3c fp=0xc00009bdb0 sp=0xc00009bd30 pc=0xb387c
os.(*Process).Wait(...)
	/data/golang/workdir/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc00019e840)
	/data/golang/workdir/go/src/os/exec/exec.go:721 +0x56 fp=0xc00009be28 sp=0xc00009bdb0 pc=0x10de26
os/exec.(*Cmd).Run(0xc00019e840)
	/data/golang/workdir/go/src/os/exec/exec.go:500 +0x6c fp=0xc00009be48 sp=0xc00009be28 pc=0x10cb6c
os/exec.(*Cmd).CombinedOutput(0xc00019e840)
	/data/golang/workdir/go/src/os/exec/exec.go:788 +0xce fp=0xc00009be70 sp=0xc00009be48 pc=0x10e21e
runtime/coverage.TestIssue56006EmitDataRaceCoverRunningGoroutine(0xc0001bc9c0)
	/data/golang/workdir/go/src/runtime/coverage/emitdata_test.go:422 +0x2d6 fp=0xc00009bf68 sp=0xc00009be70 pc=0x161ea6
testing.tRunner(0xc0001bc9c0, 0x1b4c58)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 13, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime/coverage" && test == "TestIssue56006EmitDataRaceCoverRunningGoroutine"
2022-10-04 23:29 linux-s390x-ibm go@9c2fd81e runtime/coverage.TestIssue56006EmitDataRaceCoverRunningGoroutine (log) 
panic: test timed out after 3m0s

syscall.Syscall6(0x119, 0x1, 0x2750c, 0xc00009bc98, 0x1000004, 0x0, 0x0)
	/data/golang/workdir/go/src/syscall/syscall_linux.go:90 +0x18 fp=0xc00009bc40 sp=0xc00009bbd0 pc=0x99198
os.(*Process).blockUntilWaitable(0xc0001ba270)
	/data/golang/workdir/go/src/os/wait_waitid.go:32 +0x6e fp=0xc00009bd30 sp=0xc00009bc40 pc=0xb9e3e
os.(*Process).wait(0xc0001ba270)
	/data/golang/workdir/go/src/os/exec_unix.go:22 +0x3c fp=0xc00009bdb0 sp=0xc00009bd30 pc=0xb387c
os.(*Process).Wait(...)
	/data/golang/workdir/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc00019e840)
	/data/golang/workdir/go/src/os/exec/exec.go:721 +0x56 fp=0xc00009be28 sp=0xc00009bdb0 pc=0x10de26
os/exec.(*Cmd).Run(0xc00019e840)
	/data/golang/workdir/go/src/os/exec/exec.go:500 +0x6c fp=0xc00009be48 sp=0xc00009be28 pc=0x10cb6c
os/exec.(*Cmd).CombinedOutput(0xc00019e840)
	/data/golang/workdir/go/src/os/exec/exec.go:788 +0xce fp=0xc00009be70 sp=0xc00009be48 pc=0x10e21e
runtime/coverage.TestIssue56006EmitDataRaceCoverRunningGoroutine(0xc0001bc9c0)
	/data/golang/workdir/go/src/runtime/coverage/emitdata_test.go:422 +0x2d6 fp=0xc00009bf68 sp=0xc00009be70 pc=0x161ea6
testing.tRunner(0xc0001bc9c0, 0x1b4c58)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Oct 13, 2022

This looks like a timeout, and the test is now skipped in short mode as of CL 441858.

@bcmills bcmills closed this as completed Oct 13, 2022
@bcmills bcmills added this to the Go1.20 milestone Oct 13, 2022
@thanm
Copy link
Contributor

thanm commented Oct 13, 2022

I tried a couple of runs of

   go clean -cache
   go clean -testcache
   go test -test.count=1 runtime/coverage

using a linux-s390x-ibm gomote, and appears to take around 70 seconds-- so that might explain the timeout (e.g. if the test is being run with lots of other tests simultaneously I guess).

@golang golang locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thanm thanm

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @thanm