Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/regtest/misc: TestRenamePackage failures #56194

Closed
gopherbot opened this issue Oct 13, 2022 · 4 comments
Closed

x/tools/gopls/internal/regtest/misc: TestRenamePackage failures #56194

gopherbot opened this issue Oct 13, 2022 · 4 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Oct 13, 2022

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage" && goos == "windows"

Issue created automatically to collect these failures.

Example (log):

serve.go:438: debug server listening at http://localhost:49809
serve.go:438: debug server listening at http://localhost:49810
#### Start Gopls Test Logs for "TestRenamePackage/default"
[Trace - 19:09:35.817 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-1020595064\\TestRenamePackage\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1020595064/TestRenamePackage/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1020595064/TestRenamePackage/default/work","name":"work"}]}


[Trace - 19:09:35.817 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 841873f27c4d08d266779a9ef719a7f0d1a0e74d\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...

[Trace - 19:09:36.358 PM] Received notification '$/progress'.
Params: {"token":"7424783882388715104","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestRenamePackage/default"
--- FAIL: TestRenamePackage (3.87s)
    --- FAIL: TestRenamePackage/default (1.20s)
        rename_test.go:297: rename C:\Users\gopher\AppData\Local\Temp\1\gopls-regtest-1020595064\TestRenamePackage\default\work\lib C:\Users\gopher\AppData\Local\Temp\1\gopls-regtest-1020595064\TestRenamePackage\default\work\lib1: Access is denied.
2022/10/04 19:09:53 cleaning workspace dir: remove C:\Users\gopher\AppData\Local\Temp\1\gopls-workspace-mod3570629063: The process cannot access the file because it is being used by another process.

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 13, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage"
2022-10-04 18:24 windows-amd64-longtest tools@dc88e7b4 go@841873f2 x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
serve.go:438: debug server listening at http://localhost:49809
serve.go:438: debug server listening at http://localhost:49810
#### Start Gopls Test Logs for "TestRenamePackage/default"
[Trace - 19:09:35.817 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-1020595064\\TestRenamePackage\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1020595064/TestRenamePackage/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1020595064/TestRenamePackage/default/work","name":"work"}]}


[Trace - 19:09:35.817 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 841873f27c4d08d266779a9ef719a7f0d1a0e74d\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...

[Trace - 19:09:36.358 PM] Received notification '$/progress'.
Params: {"token":"7424783882388715104","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestRenamePackage/default"
--- FAIL: TestRenamePackage (3.87s)
    --- FAIL: TestRenamePackage/default (1.20s)
        rename_test.go:297: rename C:\Users\gopher\AppData\Local\Temp\1\gopls-regtest-1020595064\TestRenamePackage\default\work\lib C:\Users\gopher\AppData\Local\Temp\1\gopls-regtest-1020595064\TestRenamePackage\default\work\lib1: Access is denied.
2022/10/04 19:09:53 cleaning workspace dir: remove C:\Users\gopher\AppData\Local\Temp\1\gopls-workspace-mod3570629063: The process cannot access the file because it is being used by another process.

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 13, 2022
@gopherbot gopherbot added this to the Unreleased milestone Oct 13, 2022
@bcmills
Copy link
Contributor

bcmills commented Oct 13, 2022

Should be fixed by CL 440181.

@bcmills bcmills closed this as completed Oct 13, 2022
@gopherbot gopherbot reopened this May 17, 2023
@gopherbot

This comment was marked as off-topic.

@bcmills
Copy link
Contributor

bcmills commented May 17, 2023

Those are #60266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants