Skip to content

x/vulndb: add deployment test to compare vuln.go.dev and data/osv* to make sure no reports are deleted #56139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Oct 11, 2022 · 2 comments
Closed

x/vulndb: add deployment test to compare vuln.go.dev and data/osv* to make sure no reports are deleted #56139

julieqiu opened this issue Oct 11, 2022 · 2 comments
Assignees
@tatianab
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/2022

Comments

@julieqiu
Copy link
Member

No description provided.

@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Oct 11, 2022
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Oct 11, 2022
@julieqiu julieqiu modified the milestones: vuln/unplanned, vuln/2022 Oct 11, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/440635 mentions this issue: all_test: add test to compare data/osv and vuln.go.dev

gopherbot pushed a commit to golang/vulndb that referenced this issue Oct 14, 2022
@julieqiu @gopherbot
all_test: add test to compare data/osv and vuln.go.dev
51ecc51 
The test is currently skipped because it fails on TryBots.

We plan to add it as a step in the deployment process to make sure that
not reports are ever deleted.

For golang/go#56139

Change-Id: If481a607174efceb73d22d6438d0465f035d40c0
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/440635
Reviewed-by: Julie Qiu <julieqiu@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Julie Qiu <julieqiu@google.com>
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
Run-TryBot: Julie Qiu <julieqiu@google.com>
@joedian joedian added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 14, 2022
@tatianab tatianab self-assigned this Jan 23, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/464935 mentions this issue: all_test: remove TODO coments for TestMissingReports

gopherbot pushed a commit to golang/vulndb that referenced this issue Feb 2, 2023
@zpavlinovic
all_test: remove TestMissingReports
b9638e6 
Updates golang/go#56139

Change-Id: I6288b65cb073730b6069512b0259a0a1e09519ed
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/464935
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
@golang golang locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tatianab tatianab

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/2022
Development

No branches or pull requests
4 participants
@julieqiu @tatianab @gopherbot @joedian