Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/exp/jsonrpc2: allow JSON-RPC2 response errors to be exploitable #56133

Open
maxatome opened this issue Oct 10, 2022 · 1 comment
Open

proposal: x/exp/jsonrpc2: allow JSON-RPC2 response errors to be exploitable #56133

maxatome opened this issue Oct 10, 2022 · 1 comment
Labels
Proposal
Milestone
Proposal

Comments

@maxatome
Copy link

jsonrpc2.wireError type is not exported, but contains useful information.

As jsonrpc2.AsyncCall.Await() returns an error, when a JSON-RPC2 error is returned by the server side, it is not possible for the caller to guess it is really a server error and also to access data it contains.

The proposal is simply to rename jsonrpc2.wireError to jsonrpc2.Error as done in https://go-review.googlesource.com/c/exp/+/415615

This way the caller can do a type assertion to check it is a server error, and then access the already exported fields.

The backward compatibility is not broken as the previous jsonrpc2.wireError type was not exported.
@gopherbot gopherbot added this to the Proposal milestone Oct 10, 2022
@maxatome maxatome mentioned this issue Oct 10, 2022
Open
@maxatome
Copy link
Author

maxatome commented Dec 8, 2022 •
edited

Does someone have any news about this proposal, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

No branches or pull requests
2 participants
@maxatome @gopherbot