Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/jsonrpc2: data race #56130

Closed
maxatome opened this issue Oct 10, 2022 · 1 comment
Closed

x/exp/jsonrpc2: data race #56130

maxatome opened this issue Oct 10, 2022 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@maxatome
Copy link

maxatome commented Oct 10, 2022 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.19.1 freebsd/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/xxx/.cache/go-build"
GOENV="/home/xxx/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="freebsd"
GOINSECURE=""
GOMODCACHE="/home/xxx/go/pkg/mod"
GOOS="freebsd"
GOPATH="/home/xxx/go"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go119"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go119/pkg/tool/freebsd_amd64"
GOVCS=""
GOVERSION="go1.19.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="cc"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1731022611=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go test -race on complex unit tests using golang.org/x/exp/jsonrpc2 as an external dependency.

What did you expect to see?

No data race.

What did you see instead?

A data race in jsonrpc2/conn.go line 312.

https://go-review.googlesource.com/c/exp/+/412334 fixes the problem.
@maxatome maxatome mentioned this issue Oct 10, 2022
Closed
@maxatome maxatome changed the title exp/jsonrpc2: data race x/exp/jsonrpc2: data race Oct 10, 2022
@gopherbot gopherbot added this to the Unreleased milestone Oct 10, 2022
@bcmills
Copy link
Contributor

bcmills commented Oct 11, 2022

Fixed by CL 412334.

@bcmills bcmills closed this as completed Oct 11, 2022
@golang golang locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@maxatome @bcmills @gopherbot