Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fuzz: array literal initialization causes ICE "unhandled stmt ASOP" while fuzzing [1.19 backport] #56106

Closed
gopherbot opened this issue Oct 8, 2022 · 2 comments
Closed

internal/fuzz: array literal initialization causes ICE "unhandled stmt ASOP" while fuzzing [1.19 backport] #56106

gopherbot opened this issue Oct 8, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.19.3

Comments

@gopherbot
Copy link
Contributor

@cuonglm requested issue #56105 to be considered for backport to the next 1.19 minor release.

For the test case, can we just use a compile -d=libfuzzer test? Otherwise, maybe it should be a cmd/go script test.

Ah right, forgot about -d=libfuzzer, I updated the test case. Thanks!

@gopherbot please backport this to go1.19
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 8, 2022
@gopherbot gopherbot mentioned this issue Oct 8, 2022
Closed
@gopherbot gopherbot added this to the Go1.19.3 milestone Oct 8, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/441995 mentions this issue: [release-branch.go1.19] cmd/compile: fix missing walk pass for static initialization slice

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Oct 12, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 12, 2022
gopherbot pushed a commit that referenced this issue Oct 24, 2022
@cuonglm @heschi
[release-branch.go1.19] cmd/compile: fix missing walk pass for static…

Verified

This commit was signed with the committer’s verified signature.
fpletz Franz Pletz
GPG key ID: 846FDED7792617B4
Verified
Learn about vigilant mode
0618956 
… initialization slice

CL 403995 fixed static init of literal contains dynamic exprs, by
ensuring their init are ordered properly. However, we still need to walk
the generated init codes before appending to parent init. Otherwise,
codes that requires desugaring will be unhandled, causing the compiler
backend crashing.

Fixes #56106

Change-Id: Ic25fd4017473f5412c8e960a91467797a234edfd
Reviewed-on: https://go-review.googlesource.com/c/go/+/440455
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/441995
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: David Chase <drchase@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 0618956 to release-branch.go1.19.

@randall77 randall77 mentioned this issue Nov 23, 2022
Closed
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@cuonglm @andrew-d
[release-branch.go1.19] cmd/compile: fix missing walk pass for static…

Verified

This commit was signed with the committer’s verified signature.
fpletz Franz Pletz
GPG key ID: 846FDED7792617B4
Verified
Learn about vigilant mode
4f311ff 
… initialization slice

CL 403995 fixed static init of literal contains dynamic exprs, by
ensuring their init are ordered properly. However, we still need to walk
the generated init codes before appending to parent init. Otherwise,
codes that requires desugaring will be unhandled, causing the compiler
backend crashing.

Fixes golang#56106

Change-Id: Ic25fd4017473f5412c8e960a91467797a234edfd
Reviewed-on: https://go-review.googlesource.com/c/go/+/440455
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/441995
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: David Chase <drchase@google.com>
@golang golang locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.19.3
Development

No branches or pull requests
2 participants
@gopherbot @joedian