Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website,x/pkgsite: add support for syntax highlighting #56081

Open
hyangah opened this issue Oct 6, 2022 · 1 comment
Open

x/website,x/pkgsite: add support for syntax highlighting #56081

hyangah opened this issue Oct 6, 2022 · 1 comment

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 6, 2022

This is an umbrella issue for syntax highlighting support in various web properties owned and maintained by the Go project

@gopherbot gopherbot added this to the Unreleased milestone Oct 6, 2022
@hyangah hyangah modified the milestones: Unreleased, pkgsite/unplanned Oct 6, 2022
@seankhliao seankhliao changed the title x/website,x/pkgsite: add support for syntax highligting x/website,x/pkgsite: add support for syntax highlighting Oct 6, 2022
@danawoodman
Copy link

danawoodman commented Sep 2, 2023

II did a brief experiment to add syntax highlighting via https://github.com/yuin/goldmark-highlighting and it seems fairly easy to accomplish. Is this something the team is open to?

Screenshot 2023-09-02 at 4 26 01 PM

All that I think is required is a bit of configuration of goldmark-highlight and changing a given code block to have the language prefixed with language like you do in Github:

image image

I think it would be pretty easy to progressively add this to pages in an incremental fashion until all properties have syntax highlighting. Is a PR welcome for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants