Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httputil: TestChunkReaderAllocs is unstable #5608

Closed
davecheney opened this issue Jun 1, 2013 · 15 comments
Closed

net/http/httputil: TestChunkReaderAllocs is unstable #5608

davecheney opened this issue Jun 1, 2013 · 15 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.3

Comments

@davecheney
Copy link
Contributor 

What steps will reproduce the problem?

After 2c4de577b1ae was applied, this test became unstable on the linux/amd64 race builder

--- FAIL: TestChunkReaderAllocs (0.00 seconds)
    chunked_test.go:69: 20 mallocs; want <= 1
FAIL
FAIL    net/http/httputil   0.145s

Please use labels and text to provide additional information.

http://build.golang.org/log/2af7a46432dbfcdec9fc9cbc28b0bc40c48314fe
http://build.golang.org/log/c8c8b126e4c58806f713db48d08218bb795d04f6

This does not appear to affect the darwin/amd64 race builder. Is darwin using the new
net poller implementation ?

Dmitry, sorry, I know you've fixed this once already.
@davecheney
Copy link
Contributor Author

Comment 1:

Issue #5525 has been merged into this issue.

@dvyukov
Copy link
Member

dvyukov commented Jun 1, 2013

Comment 2:

That merged issue was reported w/o race detector, right?
Probably I need to revive https://golang.org/cl/9782047/

@alberts
Copy link
Contributor

alberts commented Jun 5, 2013

Comment 3:

Any chance we can do something about this one? Even just disable the test until it gets
fixed properly?

@dvyukov
Copy link
Member

dvyukov commented Jun 5, 2013

Comment 4:

Yes, this is not related to race detector. Just hit it w/o -race:
--- FAIL: TestChunkReaderAllocs-16 (0.00 seconds)
    chunked_test.go:69: 21 mallocs; want <= 1
FAIL
FAIL    net/http/httputil   0.045s

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 5:

Labels changed: added priority-later, go1.2maybe, removed priority-triage.

@gopherbot
Copy link
Contributor

Comment 6 by tegoor:

ok      net     2.969s
--- FAIL: TestChunkReaderAllocs (0.03 seconds)
        chunked_test.go:67: 14 mallocs; want <= 1
FAIL
FAIL    net/http        6.938s

@davecheney
Copy link
Contributor Author

Comment 7:

@tegor - can you please provide more details. Which operating system and cpu ? Which
version of Go, etc.

@gopherbot
Copy link
Contributor

Comment 8 by tegoor:

Go version: tip 17498:3ffed73b911b
OS: windows 2003 Standard Edition SP2 32bit
CPU E5405
RAM 2G
--- FAIL: TestChunkReaderAllocs (0.03 seconds)
        chunked_test.go:67: 14 mallocs; want <= 1
FAIL
FAIL    net/http        9.266s

@gopherbot
Copy link
Contributor

Comment 9 by tegoor:

sometimes it works, sometimes it doesn't work.

@rsc
Copy link
Contributor

rsc commented Sep 10, 2013

Comment 10:

Labels changed: added testing.

@rsc
Copy link
Contributor

rsc commented Oct 2, 2013

Comment 11:

Labels changed: added go1.3, removed go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 12:

Labels changed: added release-go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 13:

Labels changed: removed go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 14:

Labels changed: added repo-main.

@bradfitz
Copy link
Contributor

Comment 15:

I haven't seen reports of this in ages. I'm going to assume something in tip fixed this
in the past 4+ months.
Please reopen if you see otherwise.

Status changed to TimedOut.

@davecheney davecheney added timedout Testing An issue that has been verified to require only test changes, not just a test failure. labels Apr 16, 2014
@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
6 participants
@bradfitz @davecheney @rsc @alberts @dvyukov @gopherbot