Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os,x/website/internal/web: TestTypeScript failures due to mismatched separators in error strings #56034

Closed
gopherbot opened this issue Oct 4, 2022 · 5 comments
Closed

os,x/website/internal/web: TestTypeScript failures due to mismatched separators in error strings #56034

gopherbot opened this issue Oct 4, 2022 · 5 comments
Assignees
@ianlancetaylor
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/website/internal/web" && test == "TestTypeScript"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTypeScript (0.07s)
    --- FAIL: TestTypeScript/file_not_found (0.01s)
        site_test.go:120: ServeHTTP() mismatch (-want +got):
              strings.Join({
              	"\n\nopen testdata",
            - 	"/",
            + 	`\`,
              	"notfound.ts: The system cannot find the file specified.\n",
              }, "")

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 4, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/website/internal/web" && test == "TestTypeScript"
2022-09-27 21:05 windows-arm64-10 website@cf701bc4 go@18888751 x/website/internal/web.TestTypeScript (log) 
--- FAIL: TestTypeScript (0.07s)
    --- FAIL: TestTypeScript/file_not_found (0.01s)
        site_test.go:120: ServeHTTP() mismatch (-want +got):
              strings.Join({
              	"\n\nopen testdata",
            - 	"/",
            + 	`\`,
              	"notfound.ts: The system cannot find the file specified.\n",
              }, "")

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Oct 4, 2022
@bcmills
Copy link
Contributor

bcmills commented Oct 4, 2022

This is fallout from https://go.dev/cl/426094; fix under discussion in https://go.dev/cl/437976.

@bcmills bcmills changed the title x/website/internal/web: TestTypeScript failures x/website/internal/web: TestTypeScript failures due to mismatched separators in error strings Oct 4, 2022
@bcmills bcmills changed the title x/website/internal/web: TestTypeScript failures due to mismatched separators in error strings os,x/website/internal/web: TestTypeScript failures due to mismatched separators in error strings Oct 4, 2022
@bcmills
Copy link
Contributor

bcmills commented Oct 4, 2022

I expect that the fix may involve changes in both the way os.DirFS reports errors and the specific errors that TestTypeScript expects to see.

@gopherbot
Copy link
Author

Change https://go.dev/cl/437976 mentions this issue: os: if dirFS.Open fails, undo use of backslashes in error message

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/website/internal/web" && test == "TestTypeScript"
2022-10-04 18:01 windows-arm64-10 website@f3791178 go@c318f191 x/website/internal/web.TestTypeScript (log) 
--- FAIL: TestTypeScript (0.21s)
    --- FAIL: TestTypeScript/file_not_found (0.01s)
        site_test.go:120: ServeHTTP() mismatch (-want +got):
              strings.Join({
              	"\n\nopen testdata",
            - 	"/",
            + 	`\`,
              	"notfound.ts: The system cannot find the file specified.\n",
              }, "")

— watchflakes

@golang golang locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianlancetaylor ianlancetaylor

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @bcmills @gopherbot