Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go help vet suggests "go install .../shadow" without @latest #56014

Closed
mjl- opened this issue Oct 3, 2022 · 1 comment
Closed

cmd/go: go help vet suggests "go install .../shadow" without @latest #56014

mjl- opened this issue Oct 3, 2022 · 1 comment
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mjl-
Copy link

mjl- commented Oct 3, 2022

What version of Go are you using (go version)?

go1.19.1

Does this issue reproduce with the latest release?

yes

What did you do?

$ go1.19.1 help vet
[...]
For example, the 'shadow' analyzer can be built and run using these commands:

  go install golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow
  go vet -vettool=$(which shadow)

[...]

What did you expect to see?

go install golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow@latest

What did you see instead?

go install golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow

It's probably enough to add @latest to https://github.com/golang/go/blob/go1.19.1/src/cmd/go/internal/vet/vet.go#L45
Or rather to https://github.com/golang/go/blob/master/src/cmd/go/internal/vet/vet.go#L45

@bcmills bcmills added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Oct 3, 2022
@bcmills bcmills added this to the Backlog milestone Oct 3, 2022
@gopherbot
Copy link

Change https://go.dev/cl/437998 mentions this issue: cmd/go: add @latest suffix for go install

@golang golang locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants