New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: openbsd/ppc64 port #56001
Comments
I confirm that I have a TalosII server allocated for this and will be following the process for adding it to the Builder Dashboard. |
Power8 is the minimum level supported by the Go ppc64 assembler, for your awareness. |
If you have the port working, and this is ppc64 (big endian), does it use ELF v1 or v2? |
This is all Joel's work, but I'll try to answer to save him time: |
CC @golang/runtime @golang/release |
Change https://go.dev/cl/439978 mentions this issue: |
Change https://go.dev/cl/439977 mentions this issue: |
This allows the cpu package to function on openbsd/ppc64. Updates golang/go#56001 Change-Id: Iff306b6091da8f7dc28dd1bd2c9ba668b5318a67 Reviewed-on: https://go-review.googlesource.com/c/sys/+/439977 Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
Updates golang/go#56001 Change-Id: Ic2c7db7a0c2056d3bbc153066c187f27508cb96c Reviewed-on: https://go-review.googlesource.com/c/sys/+/439978 Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
This proposal has been added to the active column of the proposals project |
Change https://go.dev/cl/442757 mentions this issue: |
Change https://go.dev/cl/442755 mentions this issue: |
Update golang.org/x/sys to v0.0.0-20221010170243-090e33056c14. This brings in support for openbsd/ppc64 and openbsd/riscv64. Updates golang/go#55999 Updates golang/go#56001 Change-Id: Iee13561cb1a40ef97946047c10c4eee466f34821 Reviewed-on: https://go-review.googlesource.com/c/net/+/442755 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: David Chase <drchase@google.com> Run-TryBot: Joel Sing <joel@sing.id.au>
Updates golang/go#56001 Change-Id: I9c9b826d09f4f15a144141f64b4b6d5d287721fd Reviewed-on: https://go-review.googlesource.com/c/net/+/442757 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
No objections from the release team. |
No objections from the runtime team. |
Based on the discussion above, this proposal seems like a likely accept. |
No change in consensus, so accepted. 🎉 |
Update golang.org/x/sys to v0.0.0-20221010170243-090e33056c14. This brings in support for openbsd/ppc64 and openbsd/riscv64. Updates golang/go#55999 Updates golang/go#56001 Change-Id: Iee13561cb1a40ef97946047c10c4eee466f34821 Reviewed-on: https://go-review.googlesource.com/c/net/+/442755 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: David Chase <drchase@google.com> Run-TryBot: Joel Sing <joel@sing.id.au>
Updates golang/go#56001 Change-Id: I9c9b826d09f4f15a144141f64b4b6d5d287721fd Reviewed-on: https://go-review.googlesource.com/c/net/+/442757 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
When PPC64 OpenBSD works, I would check FreeBSD PPC64. |
@n2vi that's great to hear. The tree will be open soon, so now would be a great time to get things finished up if possible. It's not a problem if it takes longer, I just want to make sure that the port isn't lying around half-finished because we collectively forgot about it. @mcmilk you might try looking at the chain of CLs ending with http://go.dev/cl/475639. |
Change https://go.dev/cl/516376 mentions this issue: |
Change https://go.dev/cl/517935 mentions this issue: |
Change https://go.dev/cl/518275 mentions this issue: |
On some platforms asmcgocall can be called with a nil g. Additionally, it can be called when already on a the system (g0) stack or on a signal stack. In these cases we do not need to switch (and/or cannot switch) to the system stack and as a result, do not need to save the g. Rework asmcgocall on ppc64x to follow the pattern used on other architectures, such as amd64 and arm64, where a separate nosave path is called in the above cases. The nil g case will be needed to support openbsd/ppc64. Updates #56001 Change-Id: I431d4200bcbc4aaddeb617aefe18590165ff2927 Reviewed-on: https://go-review.googlesource.com/c/go/+/478775 Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> Reviewed-by: Paul Murphy <murp@ibm.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Add runtime support for the openbsd/ppc64 port. Updates #56001 Change-Id: I3cf010b34f96ce269858b02f16481fdad2cd5b77 Reviewed-on: https://go-review.googlesource.com/c/go/+/475618 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Paul Murphy <murp@ibm.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Eric Grosse <grosse@gmail.com>
Add syscall support for the openbsd/ppc64 port. Updates #56001 Change-Id: I695c5c296e90645515de0c8f89f1bc57e976679d Reviewed-on: https://go-review.googlesource.com/c/go/+/475636 Reviewed-by: Eric Grosse <grosse@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Add linker support for the openbsd/ppc64 port. Updates #56001 Change-Id: I18bc19b4086599996aebfbe68f2e85e1200589ca Reviewed-on: https://go-review.googlesource.com/c/go/+/475619 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Paul Murphy <murp@ibm.com> Reviewed-by: Eric Grosse <grosse@gmail.com>
Updates #56001 Change-Id: Ic7b4ecb2e471292894c54610e8acda8822c890fb Reviewed-on: https://go-review.googlesource.com/c/go/+/518275 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Paul Murphy <murp@ibm.com> TryBot-Result: Gopher Robot <gobot@golang.org>
On some platforms asmcgocall can be called with a nil g. Additionally, it can be called when already on a the system (g0) stack or on a signal stack. In these cases we do not need to switch (and/or cannot switch) to the system stack and as a result, do not need to save the g. Rework asmcgocall on ppc64x to follow the pattern used on other architectures, such as amd64 and arm64, where a separate nosave path is called in the above cases. The nil g case will be needed to support openbsd/ppc64. Updates golang#56001 Change-Id: I431d4200bcbc4aaddeb617aefe18590165ff2927 Reviewed-on: https://go-review.googlesource.com/c/go/+/478775 Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> Reviewed-by: Paul Murphy <murp@ibm.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Add runtime support for the openbsd/ppc64 port. Updates golang#56001 Change-Id: I3cf010b34f96ce269858b02f16481fdad2cd5b77 Reviewed-on: https://go-review.googlesource.com/c/go/+/475618 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Paul Murphy <murp@ibm.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Eric Grosse <grosse@gmail.com>
Add syscall support for the openbsd/ppc64 port. Updates golang#56001 Change-Id: I695c5c296e90645515de0c8f89f1bc57e976679d Reviewed-on: https://go-review.googlesource.com/c/go/+/475636 Reviewed-by: Eric Grosse <grosse@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Add linker support for the openbsd/ppc64 port. Updates golang#56001 Change-Id: I18bc19b4086599996aebfbe68f2e85e1200589ca Reviewed-on: https://go-review.googlesource.com/c/go/+/475619 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Paul Murphy <murp@ibm.com> Reviewed-by: Eric Grosse <grosse@gmail.com>
Updates golang#56001 Change-Id: Ic7b4ecb2e471292894c54610e8acda8822c890fb Reviewed-on: https://go-review.googlesource.com/c/go/+/518275 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Paul Murphy <murp@ibm.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Updates #56001 Change-Id: I16440114ecf661e9fc17d304ab3b16bc97ef82f8 Reviewed-on: https://go-review.googlesource.com/c/go/+/517935 Run-TryBot: Joel Sing <joel@sing.id.au> Reviewed-by: Paul Murphy <murp@ibm.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
Change https://go.dev/cl/547935 mentions this issue: |
Change https://go.dev/cl/547999 mentions this issue: |
Updates #56001. For #61422. Change-Id: Ie4afbc42191b155d28945bd8f104ad7a63d30db9 Reviewed-on: https://go-review.googlesource.com/c/go/+/547999 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com>
It's the same list as 1.21, with the addition of the openbsd/ppc64 port. Generated with 'go generate'. For golang/go#40561. For golang/go#56001. Change-Id: I93d2cfd191134f524255393e8b60bf6ce7328940 Reviewed-on: https://go-review.googlesource.com/c/build/+/547935 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
Is the port done, or there are still things to do? Can we close this issue? Thanks. |
It shows up in the port list ( Thanks and congratulations! |
Change https://go.dev/cl/548218 mentions this issue: |
Updates golang#56001. For golang#61422. Change-Id: Ie4afbc42191b155d28945bd8f104ad7a63d30db9 Reviewed-on: https://go-review.googlesource.com/c/go/+/547999 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com>
This issue is intended to be both a proposal and tracking issue for an openbsd/ppc64 port of Go.
This Go port already exists and is fully functional.
We have a machine available that can run a builder for this port, along with a volunteer who is willing to run it.
Per #55998 @qbit is willing to be an additional maintainer of all OpenBSD Go ports, including this one.
/cc @qbit @golang/ppc64
The text was updated successfully, but these errors were encountered: