Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: add openbsd/riscv64 port #55999

Closed
4a6f656c opened this issue Oct 2, 2022 · 22 comments
Closed

all: add openbsd/riscv64 port #55999

4a6f656c opened this issue Oct 2, 2022 · 22 comments
Labels
Proposal Proposal-Accepted
Milestone
Go1.23

Comments

@4a6f656c
Copy link
Contributor

4a6f656c commented Oct 2, 2022 •
edited

This issue is intended to be both a proposal and tracking issue for an openbsd/riscv64 port of Go.

This Go port is already available in the OpenBSD ports tree (openbsd/ports@799c178) and is fully functional.

Unfortunately I do not currently have hardware that I can use to run a builder, however I'm working to resolve this. Obviously a builder will be necessary before it can be upstreamed, however it is incredibly difficult to support an out of tree Go port without having support in packages such as golang.org/x/sys/unix - ideally this would not be blocked by the absence of a builder and upstream port.

Per #55998 @qbit is willing to be an additional maintainer of all OpenBSD Go ports, including this one.

/cc @qbit @golang/riscv64
@ianlancetaylor
Copy link
Contributor

Side note: it's fine to add ports to x/sys/unix that are not supported by the gc compiler. There are already such ports, which are used by gccgo users, such as ppc-linux.

@mengzhuo
Copy link
Contributor

mengzhuo commented Oct 3, 2022

@4a6f656c You can apply free usage of riscv unmatched from rvlabs https://github.com/plctlab/riscv-lab-access

@4a6f656c
Copy link
Contributor Author

4a6f656c commented Oct 3, 2022

Side note: it's fine to add ports to x/sys/unix that are not supported by the gc compiler. There are already such ports, which are used by gccgo users, such as ppc-linux.

Ah, excellent - good to know. Do we need to await approval of this proposal, or is that also not required?

@4a6f656c
Copy link
Contributor Author

4a6f656c commented Oct 3, 2022

@4a6f656c You can apply free usage of riscv unmatched from rvlabs https://github.com/plctlab/riscv-lab-access

Thanks, would that give access to a dedicated board/system that could run OpenBSD? Are there any details on what is provided/how this works?

@mengzhuo
Copy link
Contributor

mengzhuo commented Oct 3, 2022

Thanks, would that give access to a dedicated board/system that could run OpenBSD? Are there any details on what is provided/how this works?

Yes, you can ssh root login into board.
You need to open up a Github issue for OS specification, how many boards you need, etc.
p.s. It's National holiday until 7th Oct, there will be delay on reply.

@ianlancetaylor
Copy link
Contributor

Do we need to await approval of this proposal, or is that also not required?

Waiting for this proposal is not required.

@ianlancetaylor
Copy link
Contributor

CC @golang/runtime @golang/release

@ianlancetaylor ianlancetaylor changed the title all: openbsd/riscv64 port proposal: all: add openbsd/riscv64 port Oct 4, 2022
@ianlancetaylor ianlancetaylor added this to the Proposal milestone Oct 4, 2022
@rsc
Copy link
Contributor

rsc commented Oct 6, 2022

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@gopherbot
Copy link

Change https://go.dev/cl/439976 mentions this issue: unix: add support for openbsd/riscv64

gopherbot pushed a commit to golang/sys that referenced this issue Oct 10, 2022
@4a6f656c
unix: add support for openbsd/riscv64
a970992 
Updates golang/go#55999

Change-Id: I2ea76f72faaddc46da0c37650de702bc7e90eea2
Reviewed-on: https://go-review.googlesource.com/c/sys/+/439976
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@rsc
Copy link
Contributor

rsc commented Oct 12, 2022

Sounds like we have two maintainers: @4a6f656c and @qbit.
We also already have openbsd and riscv64 ports separately, so the combination shouldn't add too much.

@golang/runtime, @golang/release, any objections to accepting this proposal (and this port)?

@gopherbot
Copy link

Change https://go.dev/cl/442755 mentions this issue: all: update golang.org/x/sys

@gopherbot
Copy link

Change https://go.dev/cl/442756 mentions this issue: internal/socket: add support for openbsd/riscv64

gopherbot pushed a commit to golang/net that referenced this issue Oct 17, 2022
@4a6f656c
all: update golang.org/x/sys
f25eb7e 
Update golang.org/x/sys to v0.0.0-20221010170243-090e33056c14. This brings
in support for openbsd/ppc64 and openbsd/riscv64.

Updates golang/go#55999
Updates golang/go#56001

Change-Id: Iee13561cb1a40ef97946047c10c4eee466f34821
Reviewed-on: https://go-review.googlesource.com/c/net/+/442755
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
gopherbot pushed a commit to golang/net that referenced this issue Oct 19, 2022
@4a6f656c
internal/socket: add support for openbsd/riscv64
311fa19 
Updates golang/go#55999

Change-Id: Ib8b30b898821225ccf5502c7bb483accd950697c
Reviewed-on: https://go-review.googlesource.com/c/net/+/442756
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@rsc
Copy link
Contributor

rsc commented Oct 20, 2022

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Oct 26, 2022

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: all: add openbsd/riscv64 port all: add openbsd/riscv64 port Oct 26, 2022
@rsc rsc modified the milestones: Proposal, Backlog Oct 26, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @4a6f656c
all: update golang.org/x/sys
65ce689 
Update golang.org/x/sys to v0.0.0-20221010170243-090e33056c14. This brings
in support for openbsd/ppc64 and openbsd/riscv64.

Updates golang/go#55999
Updates golang/go#56001

Change-Id: Iee13561cb1a40ef97946047c10c4eee466f34821
Reviewed-on: https://go-review.googlesource.com/c/net/+/442755
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @4a6f656c
internal/socket: add support for openbsd/riscv64
40b5b61 
Updates golang/go#55999

Change-Id: Ib8b30b898821225ccf5502c7bb483accd950697c
Reviewed-on: https://go-review.googlesource.com/c/net/+/442756
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/515515 mentions this issue: dashboard: add openbsd/riscv64 builder

gopherbot pushed a commit to golang/build that referenced this issue Aug 3, 2023
@4a6f656c
dashboard: add openbsd/riscv64 builder
44fe27b 
Updates golang/go#55999

Change-Id: I0e975e9010d40d68a8dbf57e1f90086e9b3b74dd
Reviewed-on: https://go-review.googlesource.com/c/build/+/515515
Reviewed-by: Aaron Bieber <deftly@gmail.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/518626 mentions this issue: runtime: add runtime support for openbsd/riscv64 port

@gopherbot
Copy link

Change https://go.dev/cl/518628 mentions this issue: cmd/go/testdata/mod: add golang toolchain test data for openbsd/ppc64

@gopherbot
Copy link

Change https://go.dev/cl/518629 mentions this issue: cmd/dist,internal/platform: enable openbsd/riscv64 port

@gopherbot
Copy link

Change https://go.dev/cl/518624 mentions this issue: cmd/dist,internal/platform: add openbsd/riscv64 port

@gopherbot
Copy link

Change https://go.dev/cl/518630 mentions this issue: cmd/dist,internal/platform,runtime: add cgo support for openbsd/riscv64 port

@gopherbot
Copy link

Change https://go.dev/cl/518627 mentions this issue: syscall: add syscall support for openbsd/riscv64 port

@gopherbot
Copy link

Change https://go.dev/cl/518625 mentions this issue: cmd/link: enable linking on openbsd/riscv64

gopherbot pushed a commit that referenced this issue Oct 2, 2023
@4a6f656c
cmd/dist,internal/platform: add openbsd/riscv64 port
0362f5b 
Updates #55999

Change-Id: I3c07f776919e36e4c1fdc5346f7622e5901a2902
Reviewed-on: https://go-review.googlesource.com/c/go/+/518624
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Aaron Bieber <deftly@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
gopherbot pushed a commit that referenced this issue Oct 3, 2023
@4a6f656c @gopherbot
cmd/link: enable linking on openbsd/riscv64
95ef1e7 
Updates #55999

Change-Id: I6e48e6649e19a9b2d776745c05eefb3995b6dd00
Reviewed-on: https://go-review.googlesource.com/c/go/+/518625
Reviewed-by: Aaron Bieber <deftly@gmail.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
gopherbot pushed a commit that referenced this issue Oct 4, 2023
@4a6f656c
runtime: add runtime support for openbsd/riscv64 port
57c1dfd 
Updates #55999

Change-Id: I0e80f80d49696a00d979f85230d482e24d4c2d7c
Reviewed-on: https://go-review.googlesource.com/c/go/+/518626
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Aaron Bieber <deftly@gmail.com>
gopherbot pushed a commit that referenced this issue Oct 4, 2023
@4a6f656c
syscall: add syscall support for openbsd/riscv64 port
9018601 
Updates #55999

Change-Id: I5b8452207e951e543b9be42ebcb7d62c0c023f08
Reviewed-on: https://go-review.googlesource.com/c/go/+/518627
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Aaron Bieber <deftly@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Oct 4, 2023
@4a6f656c
cmd/go/testdata/mod: add golang toolchain test data for openbsd/riscv64
a1eb658 
Updates #55999

Change-Id: I65e3bfb08ed2dd1602531902c7df8232e5151aa8
Reviewed-on: https://go-review.googlesource.com/c/go/+/518628
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Aaron Bieber <deftly@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
@dmitshur dmitshur mentioned this issue Dec 5, 2023
Open
gopherbot pushed a commit that referenced this issue Jan 25, 2024
@4a6f656c
cmd/dist,internal/platform,runtime: add cgo support for openbsd/riscv…
c51beb4 
…64 port

Updates #55999

Change-Id: Ie9a030130713f3eaf789b91d9033be3335eb9d75
Reviewed-on: https://go-review.googlesource.com/c/go/+/518630
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@dmitshur dmitshur modified the milestones: Backlog, Go1.23 Jan 25, 2024
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@4a6f656c @ezz-no
cmd/dist,internal/platform: enable openbsd/riscv64 port
accc8b1 
Fixes golang#55999

Change-Id: If76b61b660db3fefe5f9ca97500782f2a650db25
Reviewed-on: https://go-review.googlesource.com/c/go/+/518629
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@4a6f656c @ezz-no
cmd/dist,internal/platform,runtime: add cgo support for openbsd/riscv…
73ed3b4 
…64 port

Updates golang#55999

Change-Id: Ie9a030130713f3eaf789b91d9033be3335eb9d75
Reviewed-on: https://go-review.googlesource.com/c/go/+/518630
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal Proposal-Accepted
Projects
Proposals
Status: Accepted
Milestone
Go1.23
Development

No branches or pull requests
6 participants
@rsc @mengzhuo @dmitshur @ianlancetaylor @4a6f656c @gopherbot