Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/tools/cmd/present: use embed the static assets #55927

Closed
dolanor opened this issue Sep 28, 2022 · 1 comment
Closed

proposal: x/tools/cmd/present: use embed the static assets #55927

dolanor opened this issue Sep 28, 2022 · 1 comment
Labels
FrozenDueToAge Proposal
Milestone
Proposal

Comments

@dolanor
Copy link

dolanor commented Sep 28, 2022

Currently, the present tool needs to be run from the tools repository to find the static assets path or you have to pass a -base flag to point where the static assets lie.

I believe embed really would improve user experience in that case. You can use present from any directory without the hassle of locating the basePath (which, with modules, is hidden in the $GOPATH/pkg/mod/… with a very long path).
@gopherbot gopherbot added this to the Proposal milestone Sep 28, 2022
@seankhliao
Copy link
Member

Duplicate of #43459

@seankhliao seankhliao marked this as a duplicate of #43459 Sep 29, 2022
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
@golang golang locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
3 participants
@dolanor @gopherbot @seankhliao