New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/http2: TestTransportBodyRewindRace failures #55896
Labels
Milestone
Comments
gopherbot
added
the
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
label
Sep 27, 2022
Found new dashboard test flakes for:
2022-09-27 17:12 linux-amd64-race net@f4863917 go@6485e8f5 x/net/http2.TestTransportBodyRewindRace (log)
2022-09-27 17:12 linux-amd64-race net@f4863917 go@bf5805ea x/net/http2.TestTransportBodyRewindRace (log)
2022-09-27 17:12 linux-amd64-race net@f4863917 go@2b9596cb x/net/http2.TestTransportBodyRewindRace (log)
|
Change https://go.dev/cl/435535 mentions this issue: |
Found new dashboard test flakes for:
2022-09-27 17:12 freebsd-amd64-race net@f4863917 go@53773a5d x/net/http2.TestTransportBodyRewindRace (log)
2022-09-27 17:12 linux-amd64-race net@f4863917 go@d6ca2447 x/net/http2.TestTransportBodyRewindRace (log)
2022-09-27 17:12 linux-amd64-race net@f4863917 go@7f7f27f9 x/net/http2.TestTransportBodyRewindRace (log)
2022-09-27 17:12 linux-amd64-race net@f4863917 go@9d2c73a9 x/net/http2.TestTransportBodyRewindRace (log)
2022-09-27 17:12 linux-amd64-race net@f4863917 go@2614985e x/net/http2.TestTransportBodyRewindRace (log)
|
dmitshur
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Sep 30, 2022
Found new dashboard test flakes for:
2022-09-27 17:12 freebsd-amd64-race net@f4863917 go@d7dbe011 x/net/http2.TestTransportBodyRewindRace (log)
|
Last set of flake reports predates the fix in https://go.dev/cl/435535. |
WeiminShang
added a commit
to WeiminShang/net
that referenced
this issue
Nov 16, 2022
Moving the Request.Body.Close call out from the ClientConn mutex results in some cases where RoundTrip returns while the Close is still in progress. This should be legal (RoundTrip explicitly allows for this), but net/http relies on Close never being called after RoundTrip returns. Add additional synchronization to ensure Close calls complete before RoundTrip returns. Fixes golang/go#55896 Change-Id: Ie3d4773966745e83987d219927929cb56ec1a7ad Reviewed-on: https://go-review.googlesource.com/c/net/+/435535 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: