Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package removal request for github.com/pedroalbanese/edgetk #55882

Closed
pedroalbanese opened this issue Sep 26, 2022 · 14 comments
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone

Comments

@pedroalbanese
Copy link

pedroalbanese commented Sep 26, 2022

What is the path of the package that you would like to have removed?

https://pkg.go.dev/github.com/pedroalbanese/edgetk

Are you the owner of this package?

Yes!

What is the reason that you could not retract this package instead?

This folders do not exist anymore and I need the name
Please remove my old package:
https://pkg.go.dev/github.com/pedroalbanese/edgetk?utm_source=godoc

Thanks in advance!

@gopherbot gopherbot added this to the Unreleased milestone Sep 26, 2022
@seankhliao seankhliao changed the title x/pkgsite: package removal request for [type path here] x/pkgsite: package removal request for github.com/pedroalbanese/edgetk Sep 27, 2022
@seankhliao seankhliao added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Sep 27, 2022
@hyangah
Copy link
Contributor

hyangah commented Sep 27, 2022

This folders do not exist anymore and I need the name

Can you elaborate this further?
Package removal is only to hide the named package from pkg.go.dev (forever). The package will still be available from proxy.golang.org, sum.golang.org and other module proxies, so you won't be able to publish already published versions again.

@pedroalbanese
Copy link
Author

pedroalbanese commented Sep 27, 2022

Will it work if I start from the latest version? I mean, releasing version 1.2.4, will the directories present in pkg.go.dev/github.com/pedroalbanese/edgetk and previous versions disappear?

I need to host the new version of the program under the same name, but without the existing directories in godoc, which are long gone..

That program was my tests program, my vade mecum, which is a prototype that implements various algorithms to test compatibility with other tools. There is no more need to be online and the official tool I want to release does not have such directories. I would like the package to be deleted from version 1.2.3 and below.

@hyangah
Copy link
Contributor

hyangah commented Sep 29, 2022

Will it work if I start from the latest version? I mean, releasing version 1.2.4, will the directories present in pkg.go.dev/github.com/pedroalbanese/edgetk and previous versions disappear?

You will need to publish a new version (v1.2.4+) with a go.mod that specifies retraction.
See https://go.dev/ref/mod#go-mod-file-retract
Once done, they will disappear from the pkgsite at least.

@pedroalbanese
Copy link
Author

pedroalbanese commented Sep 29, 2022

But this way I would have to specify retraction in all go.mod of all versions from this one?

"github.com/pedroalbanese/edgetk@v1.2.4" could not be found.
"github.com/pedroalbanese/edgetk@v1.2.5" could not be found.
but is here:
https://github.com/pedroalbanese/edgetk

I cannot release new versions.

@pedroalbanese
Copy link
Author

pedroalbanese commented Sep 29, 2022

Listen, there is documentation referring to the pkg.go.dev website at https://pkg.go.dev/about#adding-a-package. On this page there is a section called "Removing a package" which says:

"If you would like to hide versions of a module on pkg.go.dev, as well as from the go command, you should retract them. Retracting a module version involves adding a retract directive to your go.mod file and publishing a new version.See the Go blog post New module changes in Go 1.16 and the modules reference for details.

If you cannot retract your module, you can file a request for the pkgsite team to remove your package." As I did three days ago.

Well, I need to remove the previous versions of my application and add the latest one. I can't do either one. Note that I fulfill all the requirements for "file a request" here, as the documentation says, ie: I need my module removed and I can't do it by my own means. I don't speak English and I didn't expect to have to explain myself when removing a module that belongs to me, I hope I don't have to beg or wait a week for this.

I humbly request that versions prior to 1.2.3 be removed from the server, and version 1.2.4 added. Thanks in advance.

@pedroalbanese
Copy link
Author

@hyangah
Copy link
Contributor

hyangah commented Sep 29, 2022

Sorry for all the trouble.

I see v1.2.5 was published so it should be the latest. Proxy also agrees. https://proxy.golang.org/github.com/pedroalbanese/edgetk/@latest

But for some reason, pkgsite fails to process it.

@golang/tools-team @jamalc can you help fogure out why pkgsite doesn't recognize these new versions?

@jamalc
Copy link

jamalc commented Oct 3, 2022

An issue with usage of the exclude directive in your go.mod file is preventing processing. The exclude directive requires a module path and module version.

@pedroalbanese
Copy link
Author

@jamalc What if it don't have a version? Like v0.0.0-something? I don't know what the versions are..

@pedroalbanese
Copy link
Author

pedroalbanese commented Oct 3, 2022

Now I managed to update in godoc, but the directories are still there even excluding in go.mod. This removal method does not work. Directories continue on page.

@jamalc
Copy link

jamalc commented Oct 3, 2022

The submodules only relationship to github.com/pedroalbanese/edgetk is that they share a prefix. The exclude directive has no effect on the pkgsite UI for displaying submodules.

If your goal is to keep the module github.com/pedroalbanese/edgetk visible and hide the submodules at github.com/pedroalbanese/edgetk/* we can exclude the paths below from ever being visible on pkg.go.dev. Hiding these modules no affect on what's available via the module proxy. In the future if you decide to use these paths for new packages in the github.com/pedroalbanese/edgetk module, we'll have to un-exclude them. Documentation for these modules will become unavailable on the site. Should I proceed with hiding these paths?

github.com/pedroalbanese/edgetk/c509
github.com/pedroalbanese/edgetk/ccm
github.com/pedroalbanese/edgetk/cfb8
github.com/pedroalbanese/edgetk/eax
github.com/pedroalbanese/edgetk/ecb
github.com/pedroalbanese/edgetk/groestl
github.com/pedroalbanese/edgetk/jh
github.com/pedroalbanese/edgetk/ocb
github.com/pedroalbanese/edgetk/pragma
github.com/pedroalbanese/edgetk/pragma128
github.com/pedroalbanese/edgetk/scrypt
github.com/pedroalbanese/edgetk/scrypt2
github.com/pedroalbanese/edgetk/sha128
github.com/pedroalbanese/edgetk/threefish

@pedroalbanese
Copy link
Author

Yes, please hide them. Leave only the cmd directory. Thanks

@jamalc
Copy link

jamalc commented Oct 3, 2022

Done.

@jamalc jamalc closed this as completed Oct 3, 2022
@pedroalbanese
Copy link
Author

Thank you very much!

@golang golang locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants