Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/proxy: Socks5 Authentification not working #5585

Closed
gopherbot opened this issue May 29, 2013 · 2 comments
Closed

x/net/proxy: Socks5 Authentification not working #5585

gopherbot opened this issue May 29, 2013 · 2 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

by cornel.kundt:

As defined in RFC 1929, the socks5 proxy client needs to send a 1 and not 5 in version
field of the authentification package. Authentification will fail at the moment with
"... rejected username/password" error.

Attachments:

  1. socks5proxy.patch (1332 bytes)
@davecheney
Copy link
Contributor

Comment 1:

I have not reviewed you patch, please read the contribution process outlined here,
http://golang.org/doc/contribute.html

@davecheney
Copy link
Contributor

Comment 3:

Closed by revision 64ee4bbc10fa.

Status changed to Fixed.

@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh mikioh changed the title go.net/proxy: Socks5 Authentification not working proxy: Socks5 Authentification not working Jan 4, 2015
@mikioh mikioh changed the title proxy: Socks5 Authentification not working x/net/proxy: Socks5 Authentification not working Aug 5, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davecheney @mikioh @gopherbot