Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/publicsuffix: fails to regenerate due to large size #55849

Closed
zhsj opened this issue Sep 24, 2022 · 3 comments
Closed

x/net/publicsuffix: fails to regenerate due to large size #55849

zhsj opened this issue Sep 24, 2022 · 3 comments
Assignees
@neild
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@zhsj
Copy link
Contributor

zhsj commented Sep 24, 2022 

zhsj@debian:~/go/src/golang.org/x/net/publicsuffix$ go generate .
text offset 32841 is too large, or nodeBitsTextOffset is too small
exit status 1
list.go:5: running "go": exit status 1
@gopherbot gopherbot added this to the Unreleased milestone Sep 24, 2022
@dmitshur dmitshur changed the title x/net: fail to regenerate x/net/publicsuffix x/net/publicsuffix: fails to regenerate due to large size Sep 26, 2022
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 26, 2022
@dmitshur
Copy link
Contributor

CC @neild, @ianlancetaylor.

@ianlancetaylor
Copy link
Contributor

CC @nigeltao

@gopherbot
Copy link

Change https://go.dev/cl/434695 mentions this issue: publicsuffix: change node table entry size to 40 bits

@neild neild self-assigned this Sep 26, 2022
@neild neild added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 26, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @gopherbot
publicsuffix: change node table entry size to 40 bits
57b5a8e 
The latest public suffix list overflows the 15 bits of text offset,
and we're out of bits in the node entry. Bump the node size to
40 bits.

Fixes golang/go#55849

Change-Id: Ia4b1b23799d569e4fbcfe38b4d5d9761b76f2d73
Reviewed-on: https://go-review.googlesource.com/c/net/+/434695
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Auto-Submit: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <nigeltao@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
@golang golang locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@neild neild

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@neild @zhsj @dmitshur @ianlancetaylor @gopherbot