Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: ReadRequest can leak pool entry #55835

Closed
ruz opened this issue Sep 23, 2022 · 3 comments
Closed

net/http: ReadRequest can leak pool entry #55835

ruz opened this issue Sep 23, 2022 · 3 comments
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@ruz
Copy link

ruz commented Sep 23, 2022

putTextprotoReader(tp)

Line mentioned above should be a few lines earlier before first return.

@bradfitz
Copy link
Contributor

Want to send a change moving it to its own defer a few lines up? (keeping the existing one where it's at)

@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 23, 2022
@cherrymui cherrymui changed the title net/http.ReadRequest can leak pool entry net/http: ReadRequest can leak pool entry Sep 23, 2022
@cherrymui cherrymui added this to the Backlog milestone Sep 23, 2022
@cherrymui
Copy link
Member

cc @neild

@gopherbot
Copy link

Change https://go.dev/cl/433835 mentions this issue: net/http: fix the potential leak of textproto.Reader from pool

@golang golang locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants