Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/arm64: is the doc wrong? #55832

Closed
jacobishao opened this issue Sep 23, 2022 · 2 comments
Closed

cmd/internal/obj/arm64: is the doc wrong? #55832

jacobishao opened this issue Sep 23, 2022 · 2 comments
Labels
arch-arm64 Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@jacobishao
Copy link
Contributor

jacobishao commented Sep 23, 2022 •
edited

I found that the example that document below may be wrong.

go/src/cmd/internal/obj/arm64/doc.go

Line 16 in 2551324

ADC R24, R14, R12 <=> adc x12, x24

I think that right part assembly miss a operand, maybe the right GNU assembly instruction is :
ADC R24, R14, R12 <=> adc x12, x14, x24
@jacobishao jacobishao changed the title cmd/internal/obj/arm64: may the doc is wrong? cmd/internal/obj/arm64: is the doc wrong? Sep 23, 2022
@cherrymui
Copy link
Member

I think you're right. Mind sending a CL? Thanks.

@cherrymui cherrymui added Documentation NeedsFix The path to resolution is known, but the work has not been done. arch-arm64 labels Sep 23, 2022
@cherrymui cherrymui added this to the Go1.20 milestone Sep 23, 2022
@jacobishao jacobishao mentioned this issue Sep 23, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/433575 mentions this issue: cmd/internal/obj/arm64: add missing oprand register in GNU-style asse…

@golang golang locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm64 Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

Successfully merging a pull request may close this issue.

cmd/internal/obj/arm64: add missing operand register in GNU assembly jacobishao/go
3 participants
@jacobishao @gopherbot @cherrymui