Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/exec: test hangs #5571

Closed
dvyukov opened this issue May 28, 2013 · 4 comments
Closed

os/exec: test hangs #5571

dvyukov opened this issue May 28, 2013 · 4 comments

Comments

@dvyukov
Copy link
Member

dvyukov commented May 28, 2013

With the following change:
https://code.google.com/p/go/source/detail?r=776aba85ece8d3c20c08641d28424be79fa0a1b0

os/exec test fails:
http://build.golang.org/log/91d335aeb85ff5f4855d3c168ca8dbe2da991f35

The problem is in exec_test.go:
        case "describefiles":
                for fd := uintptr(3); fd < 25; fd++ {
                        f := os.NewFile(fd, fmt.Sprintf("fd-%d", fd))
                        ln, err := net.FileListener(f)
                        if err == nil {
                                fmt.Printf("fd%d: listener %s\n", fd, ln.Addr())
                                ln.Close()
                        }
                }
                os.Exit(0)

This loop closes random file descriptors including netpoll kqueue descriptor.
@dvyukov
Copy link
Member Author

dvyukov commented May 28, 2013

Comment 1:

I am not sure what this code is trying to do.
Can it first try to syscall.Dup the fd, and if it succeeds close the duped fd?

@robpike
Copy link
Contributor

robpike commented May 28, 2013

Comment 2:

This test has been a bugbear since it went in and then went out again and then back in
again. I suggest we just delete it.

Labels changed: added priority-soon, removed priority-triage.

Status changed to Accepted.

@dvyukov
Copy link
Member Author

dvyukov commented May 28, 2013

Comment 3:

Sent https://golang.org/cl/9778048

Owner changed to @dvyukov.

Status changed to Started.

@dvyukov
Copy link
Member Author

dvyukov commented May 28, 2013

Comment 4:

This issue was closed by revision 4d6bfcf.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants