Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/windows: add GetConsoleWindow and ShowWindow functions #55353

Open
PolicyPuma4 opened this issue Sep 22, 2022 · 2 comments
Open

x/sys/windows: add GetConsoleWindow and ShowWindow functions #55353

PolicyPuma4 opened this issue Sep 22, 2022 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@PolicyPuma4
Copy link

PolicyPuma4 commented Sep 22, 2022

What version of Go are you using (go version)?

$ go version
go version go1.19.1 windows/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\REDACTED\AppData\Local\go-build
set GOENV=C:\Users\REDACTED\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\REDACTED\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\REDACTED\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.19.1
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\Users\REDACTED\Documents\Go\isgame\go.mod
set GOWORK=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\REDACTED\AppData\Local\Temp\go-build2727472867=/tmp/go-build -gno-record-gcc-switches

What did you do?

https://go.dev/play/p/xw8vr2kFP-p

What did you expect to see?

Please may the GetConsoleWindow and ShowWindow functions be added to the Golang windows package?

What did you see instead?

The GetConsoleWindow and ShowWindow functions aren't currently functions of the Golang windows package.

@cherrymui cherrymui changed the title golang.org/x/sys/windows: add GetConsoleWindow and ShowWindow functions x/sys/windows: add GetConsoleWindow and ShowWindow functions Sep 22, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 22, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 22, 2022
@cherrymui cherrymui added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest labels Sep 22, 2022
@cherrymui
Copy link
Member

cc @golang/runtime @alexbrainman @bradfitz

@alexbrainman
Copy link
Member

@PolicyPuma4

You don't need to wait for these functions to be added to golang.org/x/sys/windows package. You can just add them to you own code.

But, if you want to contribute these functions to golang.org/x/sys/windows package, here https://go.dev/doc/contribute is how to contribute.

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Development

No branches or pull requests

4 participants