Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/_content/blog: defaulting to system theme #55352

Open
fflewddur opened this issue Sep 22, 2022 · 3 comments
Open

x/website/_content/blog: defaulting to system theme #55352

fflewddur opened this issue Sep 22, 2022 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@fflewddur
Copy link

It looks like the Go blog now follows the system setting for dark or light mode. For blog posts that include diagrams, this means we have images with light backgrounds that really stand out against the dark page background, and in some cases have transparent backgrounds that break entirely. This might be one section of the site where it makes sense to keep the light theme by default; just wanted to raise this issue in case this behavior was not intended.

As an example, here's a screenshot of last year's survey results, which assumed a light theme:
image
@gopherbot gopherbot added this to the Unreleased milestone Sep 22, 2022
@cherrymui
Copy link
Member

cc @dmitshur

@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 22, 2022
@dmitshur
Copy link
Contributor

Thanks for reporting this Todd. The need for images to handle both light and dark modes applies to content on the entire Go website, including documentation, tutorials, etc. There've been some previous similar reports like #54954, maybe more.

I think this issue is known to @golang/tools-team and it'll prioritized by them as appropriate.

@fflewddur
Copy link
Author

That sounds good, thanks Dmitri! If the team decides to keep the current behavior, just let me know so the UX team can update our older developer survey charts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @fflewddur @gopherbot @cherrymui