Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/gob: runtime error: index out of range [-9223372036854775808] #55337

Closed
catenacyber opened this issue Sep 22, 2022 · 1 comment
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@catenacyber
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.17.6 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/catena/Library/Caches/go-build"
GOENV="/Users/catena/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/catena/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/catena/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.6"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/catena/go/src/github.com/catenacyber/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/pp/dc1dtf9x2js3v0jx_m010nqr0000gn/T/go-build4237848497=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.17.6 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.17.6
uname -v: Darwin Kernel Version 21.3.0: Wed Jan  5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_X86_64
ProductName:	macOS
ProductVersion:	12.2.1
BuildVersion:	21D62
lldb --version: lldb-1316.0.9.41
Apple Swift version 5.6 (swiftlang-5.6.0.323.62 clang-1316.0.20.8)
gdb --version: GNU gdb (GDB) 9.1

What did you do?

Run https://go.dev/play/p/K_IqGzLABU2

What did you expect to see?

The program finishing and printing somme dummy data

What did you see instead?

panic: runtime error: index out of range [-9223372036854775808] [recovered]
	panic: runtime error: index out of range [-9223372036854775808]

goroutine 1 [running]:
encoding/gob.catchError(0xc0000ce070)
	/usr/local/go-faketime/src/encoding/gob/error.go:38 +0x6d
panic({0x4bace0, 0xc0000c6048})
	/usr/local/go-faketime/src/runtime/panic.go:884 +0x212
encoding/gob.(*Decoder).decodeStruct(0xc0000ce000?, 0xc0000c40c0, {0x4bbd00?, 0xc0000b1540?, 0x46945a?})
	/usr/local/go-faketime/src/encoding/gob/decode.go:462 +0x2cc
encoding/gob.(*Decoder).decodeValue(0xc0000ce000, 0x93e18?, {0x4afb20?, 0xc0000b1540?, 0xc0000ce018?})
	/usr/local/go-faketime/src/encoding/gob/decode.go:1210 +0x24e
encoding/gob.(*Decoder).recvType(0xc0000ce000, 0x80)
	/usr/local/go-faketime/src/encoding/gob/decoder.go:67 +0x13c
encoding/gob.(*Decoder).decodeTypeSequence(0xc0000ce000, 0x0)
	/usr/local/go-faketime/src/encoding/gob/decoder.go:164 +0x7b
encoding/gob.(*Decoder).DecodeValue(0xc0000ce000, {0x0?, 0x0?, 0x7f13ee871998?})
	/usr/local/go-faketime/src/encoding/gob/decoder.go:225 +0x18f
encoding/gob.(*Decoder).Decode(0x4e8868?, {0x0?, 0x0?})
	/usr/local/go-faketime/src/encoding/gob/decoder.go:193 +0x17a
main.main()
	/tmp/sandbox3507802547/prog.go:14 +0xb1

Program exited.

Found by https://github.com/catenacyber/ngolo-fuzzing on oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51348

cc @rolandshoemaker

The team decided on treating this issue as PUBLIC track per our security policy, in particular because the documentation for Decoder indicates it is not designed with adversarial inputs in mind

@gopherbot
Copy link

Change https://go.dev/cl/432715 mentions this issue: encoding/gob: prevent a decoder state overflow

@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 22, 2022
@cherrymui cherrymui added this to the Backlog milestone Sep 22, 2022
@golang golang locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants