x/tools/gopls/internal/regtest/misc: TestRenameFileFromEditor failures #55324

gopherbot · 2022-09-21T19:00:36Z

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenameFileFromEditor" && `err:context deadline exceeded`

Issue created automatically to collect these failures.

Example (log):

serve.go:442: debug server listening at http://localhost:37577
serve.go:442: debug server listening at http://localhost:35783
#### Start Gopls Test Logs for "TestRenameFileFromEditor/default"
[Trace - 12:43:35.823 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-463062205/TestRenameFileFromEditor/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-463062205/TestRenameFileFromEditor/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-463062205/TestRenameFileFromEditor/default/work","name":"work"}]}


[Trace - 12:43:35.823 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.18.6\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRenameFileFromEditor (517.95s)
    --- FAIL: TestRenameFileFromEditor/default (517.95s)
        rename_test.go:192: waiting on:
            Unmet: x/a.go: diagnostic at {line:2, column:6} (location of "X")
            Unmet: x/x.go: diagnostic at {line:2, column:6} (location of "X")

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
...
            	x (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	diagnosing files changed on disk: 3
            	diagnosing opened files: 3
            	diagnosing close files: 2
            	Load: 7
            	Setting up workspace: 1

— watchflakes

The text was updated successfully, but these errors were encountered:

gopherbot · 2022-09-21T19:00:55Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenameFileFromEditor"

2022-09-20 16:27 linux-s390x-ibm tools@6782af03 go@d5a5db3b x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)

serve.go:442: debug server listening at http://localhost:37577
serve.go:442: debug server listening at http://localhost:35783
#### Start Gopls Test Logs for "TestRenameFileFromEditor/default"
[Trace - 12:43:35.823 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-463062205/TestRenameFileFromEditor/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-463062205/TestRenameFileFromEditor/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-463062205/TestRenameFileFromEditor/default/work","name":"work"}]}


[Trace - 12:43:35.823 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.18.6\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRenameFileFromEditor (517.95s)
    --- FAIL: TestRenameFileFromEditor/default (517.95s)
        rename_test.go:192: waiting on:
            Unmet: x/a.go: diagnostic at {line:2, column:6} (location of "X")
            Unmet: x/x.go: diagnostic at {line:2, column:6} (location of "X")

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
...
            	x (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	diagnosing files changed on disk: 3
            	diagnosing opened files: 3
            	diagnosing close files: 2
            	Load: 7
            	Setting up workspace: 1

— watchflakes

gopherbot · 2022-10-04T18:44:05Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenameFileFromEditor"

2022-10-04 16:29 windows-386-2008 tools@7f79a022 go@0a723816 x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)

serve.go:438: debug server listening at http://localhost:49244
serve.go:438: debug server listening at http://localhost:49245
#### Start Gopls Test Logs for "TestRenameFileFromEditor/default"
[Trace - 17:49:32.768 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\gopls-regtest-1861821757\\TestRenameFileFromEditor\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/gopls-regtest-1861821757/TestRenameFileFromEditor/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/gopls-regtest-1861821757/TestRenameFileFromEditor/default/work","name":"work"}]}


[Trace - 17:49:32.769 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.18.6\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...


[Trace - 17:49:33.389 PM] Received notification '$/progress'.
Params: {"token":"8242278085718999972","value":{"kind":"begin","title":"diagnosing close files","message":"Calculating file diagnostics..."}}


#### End Gopls Test Logs for "TestRenameFileFromEditor/default"
--- FAIL: TestRenameFileFromEditor (0.95s)
    --- FAIL: TestRenameFileFromEditor/default (0.95s)
        rename_test.go:408: rename C:\Users\gopher\AppData\Local\Temp\gopls-regtest-1861821757\TestRenameFileFromEditor\default\work\a C:\Users\gopher\AppData\Local\Temp\gopls-regtest-1861821757\TestRenameFileFromEditor\default\work\x: Access is denied.

— watchflakes

gopherbot · 2022-10-07T19:02:28Z

Change https://go.dev/cl/440181 mentions this issue: gopls/internal/lsp/fake: retry ephemeral errors when renaming on windows

Investigation of renaming flakes revealed that renaming is known to be flaky on windows, and the go command has a robustio package that works around known flakes for certain IO operations on darwin and windows. Rather than duplicate this logic piecemeal, copy the entire robustio package to the gopls module, along with a script to sync it from GOROOT using go generate. Use this new package to de-flake renaming, and replace an existing workaround. The copy script got a little out of hand at the point where I needed to add +build constraints. Nevertheless, I've decided to keep it with the caveat that it may be removed if it proves too difficult to maintain. As is, it at least serves as documentation for how the sync was done. For golang/go#56040 For golang/go#56039 For golang/go#56038 For golang/go#55324 Change-Id: Ifeda408ac44a2866e84015a2a38ae340dc0a88bb Reviewed-on: https://go-review.googlesource.com/c/tools/+/440181 Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com>

findleyr · 2022-10-13T18:08:12Z

Fixed by https://go.dev/cl/440181.

gopherbot · 2022-10-25T17:38:25Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenameFileFromEditor"

2022-10-19 15:24 linux-s390x-ibm tools@d67c3ada go@6b22572e x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)

serve.go:438: debug server listening at http://localhost:37589
serve.go:438: debug server listening at http://localhost:42955
#### Start Gopls Test Logs for "TestRenameFileFromEditor/default"
[Trace - 12:50:58.375 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-925668265/TestRenameFileFromEditor/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-925668265/TestRenameFileFromEditor/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-925668265/TestRenameFileFromEditor/default/work","name":"work"}]}


[Trace - 12:50:58.375 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 6b22572e700235fb7303c7fd6aefcc33c743a130\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRenameFileFromEditor (550.31s)
    --- FAIL: TestRenameFileFromEditor/default (550.31s)
        rename_test.go:439: waiting on:
            Unmet: x/a.go: diagnostic at {line:2, column:6} (location of "X")
            Unmet: x/x.go: diagnostic at {line:2, column:6} (location of "X")

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
...
            	a/x.go (version 0):

            #### outstanding work:
            #### completed work:
            	Load: 6
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	diagnosing files changed on disk: 3
            	diagnosing opened files: 3
            	diagnosing close files: 2

— watchflakes

gopherbot · 2022-10-26T23:04:38Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenameFileFromEditor"

2022-10-26 15:27 netbsd-amd64-9_0 tools@de675d54 go@3afba312 x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)

serve.go:438: debug server listening at http://localhost:65457
serve.go:438: debug server listening at http://localhost:65456
#### Start Gopls Test Logs for "TestRenameFileFromEditor/default"
[Trace - 16:38:50.389 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-3577240223/TestRenameFileFromEditor/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-3577240223/TestRenameFileFromEditor/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-3577240223/TestRenameFileFromEditor/default/work","name":"work"}]}


[Trace - 16:38:50.391 PM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 3afba3124df90f1b2f56d3324793f16649a2d93a\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRenameFileFromEditor (530.93s)
    --- FAIL: TestRenameFileFromEditor/default (530.93s)
        rename_test.go:440: waiting on:
            Unmet: x/a.go: diagnostic at {line:2, column:6} (location of "X")
            Unmet: x/x.go: diagnostic at {line:2, column:6} (location of "X")

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
...
            	a/a.go (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing files changed on disk: 3
            	diagnosing opened files: 3
            	diagnosing close files: 2
            	Load: 6
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1

— watchflakes

gopherbot · 2022-12-06T20:34:58Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenameFileFromEditor"

2022-12-06 20:14 linux-s390x-ibm tools@6b505011 go@0d8a92bd x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)

serve.go:434: debug server listening at http://localhost:41763
serve.go:434: debug server listening at http://localhost:44627
2022/12/06 15:24:25 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3197: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRenameFileFromEditor/default"
[Trace - 15:25:03.412 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3049528075/TestRenameFileFromEditor/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3049528075/TestRenameFileFromEditor/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3049528075/TestRenameFileFromEditor/default/work","name":"work"}]}


[Trace - 15:25:03.412 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRenameFileFromEditor (531.36s)
    --- FAIL: TestRenameFileFromEditor/default (531.36s)
        rename_test.go:440: waiting on:
            Unmet: x/a.go: diagnostic at {line:2, column:6} (location of "X")
            Unmet: x/x.go: diagnostic at {line:2, column:6} (location of "X")

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
...
            	a/a.go (version 0):
            	a/x.go (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	diagnosing close files: 2
            	diagnosing files changed on disk: 3
            	Setting up workspace: 1
            	diagnosing opened files: 3

— watchflakes

gopherbot · 2023-01-10T20:56:50Z

Change https://go.dev/cl/461416 mentions this issue: internal/regtest/misc: fail eagerly in TestRenameFileFromEditor

gopherbot · 2023-01-10T21:45:30Z

Change https://go.dev/cl/461418 mentions this issue: gopls/internal/lsp/cache: don't cache if mtime is too recent

Updates golang/go#55324 Change-Id: I07cb5465afc7f9e76cad96cb5fbe55e6e16a73b7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/461416 Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com>

bcmills · 2023-05-17T15:02:13Z

#60266.

gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 21, 2022

gopherbot added this to the Unreleased milestone Sep 21, 2022

hyangah modified the milestones: Unreleased, gopls/later Sep 23, 2022

findleyr closed this as completed Oct 13, 2022

findleyr self-assigned this Oct 13, 2022

findleyr modified the milestones: gopls/later, gopls/v0.10.0 Oct 20, 2022

gopherbot reopened this Oct 25, 2022

findleyr modified the milestones: gopls/v0.10.0, gopls/v0.10.1 Oct 26, 2022

findleyr modified the milestones: gopls/v0.10.1, gopls/v0.10.2 Nov 1, 2022

findleyr modified the milestones: gopls/v0.11.0, gopls/v0.12.0 Dec 8, 2022

gopherbot closed this as completed in golang/tools@4305a22 Jan 11, 2023

gopherbot reopened this May 17, 2023

This comment was marked as off-topic.

Sign in to view

bcmills closed this as completed May 17, 2023

bcmills mentioned this issue May 17, 2023

x/tools/gopls: test failures due to rename permission errors on linux-amd64-wsl #60266

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls/internal/regtest/misc: TestRenameFileFromEditor failures #55324

x/tools/gopls/internal/regtest/misc: TestRenameFileFromEditor failures #55324

gopherbot commented Sep 21, 2022 •

edited by bcmills

gopherbot commented Sep 21, 2022

gopherbot commented Oct 4, 2022

gopherbot commented Oct 7, 2022

findleyr commented Oct 13, 2022 •

edited

gopherbot commented Oct 25, 2022

gopherbot commented Oct 26, 2022

gopherbot commented Dec 6, 2022

gopherbot commented Jan 10, 2023

gopherbot commented Jan 10, 2023

This comment was marked as off-topic.

bcmills commented May 17, 2023

x/tools/gopls/internal/regtest/misc: TestRenameFileFromEditor failures #55324

x/tools/gopls/internal/regtest/misc: TestRenameFileFromEditor failures #55324

Comments

gopherbot commented Sep 21, 2022 • edited by bcmills

gopherbot commented Sep 21, 2022

gopherbot commented Oct 4, 2022

gopherbot commented Oct 7, 2022

findleyr commented Oct 13, 2022 • edited

gopherbot commented Oct 25, 2022

gopherbot commented Oct 26, 2022

gopherbot commented Dec 6, 2022

gopherbot commented Jan 10, 2023

gopherbot commented Jan 10, 2023

This comment was marked as off-topic.

bcmills commented May 17, 2023

gopherbot commented Sep 21, 2022 •

edited by bcmills

findleyr commented Oct 13, 2022 •

edited