Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/internal/wycheproof: TestHkdf failures #55316

Closed
gopherbot opened this issue Sep 21, 2022 · 2 comments
Closed

x/crypto/internal/wycheproof: TestHkdf failures #55316

gopherbot opened this issue Sep 21, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/crypto/internal/wycheproof" && test == "TestHkdf"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestHkdf (0.02s)
panic: runtime error: cgo argument has Go pointer to Go pointer [recovered]
	panic: runtime error: cgo argument has Go pointer to Go pointer

goroutine 1732 [running]:
testing.tRunner.func1.2({0x740ea0, 0xc00006ecb0})
	/workdir/go/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1399 +0x39f
panic({0x740ea0, 0xc00006ecb0})
	/workdir/go/src/runtime/panic.go:884 +0x212
crypto/internal/boring.(*boringHMAC).Reset.func1(0xc000479c20)
	/workdir/go/src/crypto/internal/boring/hmac.go:107 +0x57
crypto/internal/boring.(*boringHMAC).Reset(0xc000479c20)
	/workdir/go/src/crypto/internal/boring/hmac.go:107 +0x94
crypto/internal/boring.NewHMAC(0xc000641b88?, {0xc000024d20, 0x38, 0x0?})
	/workdir/go/src/crypto/internal/boring/hmac.go:79 +0x125
crypto/hmac.New(0xc000641cd8, {0xc000024d20, 0x38, 0x70})
	/workdir/go/src/crypto/hmac/hmac.go:131 +0x31
golang.org/x/crypto/hkdf.Extract(0xc00044bc20?, {0xc000476a00, 0x20, 0x40}, {0xc000024d20?, 0x20?, 0x30?})
	/workdir/gopath/src/golang.org/x/crypto/hkdf/hkdf.go:30 +0x85
golang.org/x/crypto/hkdf.New(0x15?, {0xc000476a00?, 0x20?, 0x82d248?}, {0xc000024d20?, 0xc000057ca0?, 0x5c57f9?}, {0xc00044bc20, 0x14, 0x30})
	/workdir/gopath/src/golang.org/x/crypto/hkdf/hkdf.go:91 +0x2b
golang.org/x/crypto/internal/wycheproof.TestHkdf(0xc000600820)
	/workdir/gopath/src/golang.org/x/crypto/internal/wycheproof/hkdf_test.go:95 +0x450
testing.tRunner(0xc000600820, 0x792668)
	/workdir/go/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1493 +0x35f

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 21, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 21, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/crypto/internal/wycheproof" && test == "TestHkdf"
2022-08-17 18:37 linux-amd64-boringcrypto crypto@04dced17 go@57d05512 x/crypto/internal/wycheproof.TestHkdf (log) 
--- FAIL: TestHkdf (0.02s)
panic: runtime error: cgo argument has Go pointer to Go pointer [recovered]
	panic: runtime error: cgo argument has Go pointer to Go pointer

goroutine 1732 [running]:
testing.tRunner.func1.2({0x740ea0, 0xc00006ecb0})
	/workdir/go/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1399 +0x39f
panic({0x740ea0, 0xc00006ecb0})
	/workdir/go/src/runtime/panic.go:884 +0x212
crypto/internal/boring.(*boringHMAC).Reset.func1(0xc000479c20)
	/workdir/go/src/crypto/internal/boring/hmac.go:107 +0x57
crypto/internal/boring.(*boringHMAC).Reset(0xc000479c20)
	/workdir/go/src/crypto/internal/boring/hmac.go:107 +0x94
crypto/internal/boring.NewHMAC(0xc000641b88?, {0xc000024d20, 0x38, 0x0?})
	/workdir/go/src/crypto/internal/boring/hmac.go:79 +0x125
crypto/hmac.New(0xc000641cd8, {0xc000024d20, 0x38, 0x70})
	/workdir/go/src/crypto/hmac/hmac.go:131 +0x31
golang.org/x/crypto/hkdf.Extract(0xc00044bc20?, {0xc000476a00, 0x20, 0x40}, {0xc000024d20?, 0x20?, 0x30?})
	/workdir/gopath/src/golang.org/x/crypto/hkdf/hkdf.go:30 +0x85
golang.org/x/crypto/hkdf.New(0x15?, {0xc000476a00?, 0x20?, 0x82d248?}, {0xc000024d20?, 0xc000057ca0?, 0x5c57f9?}, {0xc00044bc20, 0x14, 0x30})
	/workdir/gopath/src/golang.org/x/crypto/hkdf/hkdf.go:91 +0x2b
golang.org/x/crypto/internal/wycheproof.TestHkdf(0xc000600820)
	/workdir/gopath/src/golang.org/x/crypto/internal/wycheproof/hkdf_test.go:95 +0x450
testing.tRunner(0xc000600820, 0x792668)
	/workdir/go/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1493 +0x35f
2022-08-17 18:37 linux-amd64-boringcrypto crypto@04dced17 go@ebda5a73 x/crypto/internal/wycheproof.TestHkdf (log) 
--- FAIL: TestHkdf (0.00s)
panic: runtime error: cgo argument has Go pointer to Go pointer [recovered]
	panic: runtime error: cgo argument has Go pointer to Go pointer

goroutine 879 [running]:
testing.tRunner.func1.2({0x740ea0, 0xc00014f2b0})
	/workdir/go/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1399 +0x39f
panic({0x740ea0, 0xc00014f2b0})
	/workdir/go/src/runtime/panic.go:884 +0x212
crypto/internal/boring.(*boringHMAC).Reset.func1(0xc0001efd40)
	/workdir/go/src/crypto/internal/boring/hmac.go:107 +0x57
crypto/internal/boring.(*boringHMAC).Reset(0xc0001efd40)
	/workdir/go/src/crypto/internal/boring/hmac.go:107 +0x94
crypto/internal/boring.NewHMAC(0xc000173b88?, {0xc0003ebb90, 0x41, 0x0?})
	/workdir/go/src/crypto/internal/boring/hmac.go:79 +0x125
crypto/hmac.New(0xc000173cd8, {0xc0003ebb90, 0x41, 0x90})
	/workdir/go/src/crypto/hmac/hmac.go:131 +0x31
golang.org/x/crypto/hkdf.Extract(0xc0001cd410?, {0xc0001cd3e0, 0x14, 0x30}, {0xc0003ebb90?, 0x20?, 0x30?})
	/workdir/gopath/src/golang.org/x/crypto/hkdf/hkdf.go:30 +0x85
golang.org/x/crypto/hkdf.New(0x13?, {0xc0001cd3e0?, 0x20?, 0x82d248?}, {0xc0003ebb90?, 0xc00037b4a0?, 0x5c57f9?}, {0xc0001cd410, 0x14, 0x30})
	/workdir/gopath/src/golang.org/x/crypto/hkdf/hkdf.go:91 +0x2b
golang.org/x/crypto/internal/wycheproof.TestHkdf(0xc00042a1a0)
	/workdir/gopath/src/golang.org/x/crypto/internal/wycheproof/hkdf_test.go:95 +0x450
testing.tRunner(0xc00042a1a0, 0x792648)
	/workdir/go/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1493 +0x35f

— watchflakes

@rsc
Copy link
Contributor

rsc commented Sep 21, 2022

Duplicate of #55318.

@rsc rsc closed this as completed Sep 21, 2022
@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@rsc @gopherbot