Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: TestProtocolErrorAfterGoAway failures #55284

Closed
gopherbot opened this issue Sep 20, 2022 · 3 comments
Closed

x/net/http2: TestProtocolErrorAfterGoAway failures #55284

gopherbot opened this issue Sep 20, 2022 · 3 comments
Assignees
@rsc
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestProtocolErrorAfterGoAway"

Bug automatically created to collect these failures.

Example log:

panic: test timed out after 10m0s

internal/poll.runtime_pollWait(0x128cea008, 0x72)
	/tmp/buildlet/go/src/runtime/netpoll.go:306 +0xa0
internal/poll.(*pollDesc).wait(0x140001ff580?, 0x14000342a00?, 0x0)
	/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x140001ff580, {0x14000342a00, 0x700, 0x700})
	/tmp/buildlet/go/src/internal/poll/fd_unix.go:167 +0x200
...
	/tmp/buildlet/go/src/io/io.go:351
golang.org/x/net/http2.readFrameHeader({0x1400034ee40?, 0x9?, 0x1?}, {0x101137cc8?, 0x140003df180?})
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/frame.go:237 +0x58
golang.org/x/net/http2.(*Framer).ReadFrame(0x1400034ee00)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/frame.go:498 +0x84
golang.org/x/net/http2.(*serverTester).readFrame(...)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/server_test.go:486
golang.org/x/net/http2.TestProtocolErrorAfterGoAway(0x1400058fd40)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/server_test.go:4392 +0x1a0
testing.tRunner(0x1400058fd40, 0x101134a08)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestProtocolErrorAfterGoAway"
2022-09-19 23:24 darwin-arm64-11 net@f2f64ebc go@1e7e160d golang.org/x/net/http2.TestProtocolErrorAfterGoAway (log) 
panic: test timed out after 10m0s

internal/poll.runtime_pollWait(0x128cea008, 0x72)
	/tmp/buildlet/go/src/runtime/netpoll.go:306 +0xa0
internal/poll.(*pollDesc).wait(0x140001ff580?, 0x14000342a00?, 0x0)
	/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x140001ff580, {0x14000342a00, 0x700, 0x700})
	/tmp/buildlet/go/src/internal/poll/fd_unix.go:167 +0x200
...
	/tmp/buildlet/go/src/io/io.go:351
golang.org/x/net/http2.readFrameHeader({0x1400034ee40?, 0x9?, 0x1?}, {0x101137cc8?, 0x140003df180?})
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/frame.go:237 +0x58
golang.org/x/net/http2.(*Framer).ReadFrame(0x1400034ee00)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/frame.go:498 +0x84
golang.org/x/net/http2.(*serverTester).readFrame(...)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/server_test.go:486
golang.org/x/net/http2.TestProtocolErrorAfterGoAway(0x1400058fd40)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/server_test.go:4392 +0x1a0
testing.tRunner(0x1400058fd40, 0x101134a08)
2022-09-19 23:24 darwin-arm64-12 net@f2f64ebc go@1e7e160d golang.org/x/net/http2.TestProtocolErrorAfterGoAway (log) 
panic: test timed out after 10m0s

internal/poll.runtime_pollWait(0x12ac33588, 0x72)
	/tmp/buildlet/go/src/runtime/netpoll.go:306 +0xa0
internal/poll.(*pollDesc).wait(0x14000398b80?, 0x140007aa000?, 0x0)
	/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x14000398b80, {0x140007aa000, 0x700, 0x700})
	/tmp/buildlet/go/src/internal/poll/fd_unix.go:167 +0x200
...
	/tmp/buildlet/go/src/io/io.go:351
golang.org/x/net/http2.readFrameHeader({0x140002739a0?, 0x9?, 0x1?}, {0x102fd7cc8?, 0x140001d4700?})
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/frame.go:237 +0x58
golang.org/x/net/http2.(*Framer).ReadFrame(0x14000273960)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/frame.go:498 +0x84
golang.org/x/net/http2.(*serverTester).readFrame(...)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/server_test.go:486
golang.org/x/net/http2.TestProtocolErrorAfterGoAway(0x14000407d40)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/server_test.go:4392 +0x1a0
testing.tRunner(0x14000407d40, 0x102fd4a08)
2022-09-19 23:24 linux-amd64-wsl net@f2f64ebc go@1e7e160d golang.org/x/net/http2.TestProtocolErrorAfterGoAway (log) 
panic: test timed out after 10m0s

internal/poll.runtime_pollWait(0x7f831c7b8d78, 0x72)
	/tmp/workdir-host-linux-amd64-wsl/go/src/runtime/netpoll.go:306 +0x89
internal/poll.(*pollDesc).wait(0xc000a83200?, 0xc00032e300?, 0x0)
	/tmp/workdir-host-linux-amd64-wsl/go/src/internal/poll/fd_poll_runtime.go:84 +0x32
internal/poll.(*pollDesc).waitRead(...)
	/tmp/workdir-host-linux-amd64-wsl/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc000a83200, {0xc00032e300, 0x700, 0x700})
	/tmp/workdir-host-linux-amd64-wsl/go/src/internal/poll/fd_unix.go:167 +0x299
...
	/tmp/workdir-host-linux-amd64-wsl/go/src/io/io.go:351
golang.org/x/net/http2.readFrameHeader({0xc0002c8580?, 0x9?, 0x1?}, {0x8c4940?, 0xc000383180?})
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/frame.go:237 +0x6e
golang.org/x/net/http2.(*Framer).ReadFrame(0xc0002c8540)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/frame.go:498 +0x95
golang.org/x/net/http2.(*serverTester).readFrame(...)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/server_test.go:486
golang.org/x/net/http2.TestProtocolErrorAfterGoAway(0xc00058b520)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/server_test.go:4392 +0x225
testing.tRunner(0xc00058b520, 0x86f660)
2022-09-19 23:24 linux-amd64-wsl net@f2f64ebc go@cf53990b golang.org/x/net/http2.TestProtocolErrorAfterGoAway (log) 
panic: test timed out after 10m0s

internal/poll.runtime_pollWait(0x7f7f68be0b88, 0x72)
	/tmp/workdir-host-linux-amd64-wsl/go/src/runtime/netpoll.go:306 +0x89
internal/poll.(*pollDesc).wait(0xc000a72f80?, 0xc000769100?, 0x0)
	/tmp/workdir-host-linux-amd64-wsl/go/src/internal/poll/fd_poll_runtime.go:84 +0x32
internal/poll.(*pollDesc).waitRead(...)
	/tmp/workdir-host-linux-amd64-wsl/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc000a72f80, {0xc000769100, 0x700, 0x700})
	/tmp/workdir-host-linux-amd64-wsl/go/src/internal/poll/fd_unix.go:167 +0x299
...
	/tmp/workdir-host-linux-amd64-wsl/go/src/io/io.go:351
golang.org/x/net/http2.readFrameHeader({0xc0002b8820?, 0x9?, 0x1?}, {0x8d18e0?, 0xc0000c7180?})
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/frame.go:237 +0x6e
golang.org/x/net/http2.(*Framer).ReadFrame(0xc0002b87e0)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/frame.go:498 +0x95
golang.org/x/net/http2.(*serverTester).readFrame(...)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/server_test.go:486
golang.org/x/net/http2.TestProtocolErrorAfterGoAway(0xc0003c3380)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/net/http2/server_test.go:4392 +0x225
testing.tRunner(0xc0003c3380, 0x87c668)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Sep 20, 2022

Fixed by https://go.dev/cl/432037.

@bcmills bcmills closed this as completed Sep 20, 2022
@rsc rsc reopened this Sep 20, 2022
@rsc rsc self-assigned this Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Another case for my deflaking logic.

@rsc rsc closed this as completed Sep 21, 2022
@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rsc rsc

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rsc @bcmills @gopherbot