Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/completion: TestPostfixSnippetCompletion failures #55278

Open
gopherbot opened this issue Sep 20, 2022 · 3 comments
Open

x/tools/gopls/internal/regtest/completion: TestPostfixSnippetCompletion failures #55278

gopherbot opened this issue Sep 20, 2022 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/completion" && test == "TestPostfixSnippetCompletion"

Bug automatically created to collect these failures.

Example log:

panic: test timed out after 10m0s

testing.(*T).Run(0xc00305a4e0, {0x1ab1aee?, 0xc000cf6160?}, 0xc001f17cc0)
	/Users/gopher/workdir/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/internal/lsp/regtest.(*Runner).Run(0xc0004ae640, 0xc00305a4e0, {0x1af40be, 0x26}, 0xc000cf6160, {0xc00006ff50, 0x1, 0x421bc1ec91?})
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/runner.go:268 +0x3e5
golang.org/x/tools/internal/lsp/regtest.configuredRunner.Run(...)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/regtest.go:66
golang.org/x/tools/gopls/internal/regtest/completion.TestPostfixSnippetCompletion(0xc0029991e0?)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/completion/postfix_snippet_test.go:440 +0x13d
testing.tRunner(0xc00305a4e0, 0x1c20200)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/completion" && test == "TestPostfixSnippetCompletion"
2022-08-15 17:37 darwin-amd64-12_0 tools@987de349 go@1f833e4a golang.org/x/tools/gopls/internal/regtest/completion.TestPostfixSnippetCompletion (log) 
panic: test timed out after 10m0s

testing.(*T).Run(0xc00305a4e0, {0x1ab1aee?, 0xc000cf6160?}, 0xc001f17cc0)
	/Users/gopher/workdir/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/internal/lsp/regtest.(*Runner).Run(0xc0004ae640, 0xc00305a4e0, {0x1af40be, 0x26}, 0xc000cf6160, {0xc00006ff50, 0x1, 0x421bc1ec91?})
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/runner.go:268 +0x3e5
golang.org/x/tools/internal/lsp/regtest.configuredRunner.Run(...)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/regtest.go:66
golang.org/x/tools/gopls/internal/regtest/completion.TestPostfixSnippetCompletion(0xc0029991e0?)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/completion/postfix_snippet_test.go:440 +0x13d
testing.tRunner(0xc00305a4e0, 0x1c20200)
2022-09-07 22:05 darwin-arm64-11 tools@a6307518 go@51fdfeb1 golang.org/x/tools/gopls/internal/regtest/completion.TestPostfixSnippetCompletion (log) 
panic: test timed out after 10m0s

testing.(*T).Run(0x14002878ea0, {0x100b16e4d?, 0x14000077e68?}, 0x1400274bc20)
	/tmp/buildlet/go/src/testing/testing.go:1527 +0x314
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0x14000339180, 0x14002878ea0, {0x100b5944f, 0x26}, 0x1400078d800, {0x14000077f48, 0x1, 0x1003a7f6c?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:268 +0x394
golang.org/x/tools/gopls/internal/lsp/regtest.configuredRunner.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:66
golang.org/x/tools/gopls/internal/regtest/completion.TestPostfixSnippetCompletion(0x140030b0000?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/completion/postfix_snippet_test.go:440 +0x150
testing.tRunner(0x14002878ea0, 0x100f21e28)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@suzmue suzmue modified the milestones: Unreleased, gopls/later Oct 3, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/completion" && test == "TestPostfixSnippetCompletion"
2023-06-26 14:06 darwin-arm64-12 tools@9d8d4089 go@9a2e6c9c x/tools/gopls/internal/regtest/completion.TestPostfixSnippetCompletion (log) 
panic: test timed out after 10m0s

testing.(*T).Run(0x14002e929c0, {0x102aa6c43?, 0x102ac3c19?}, 0x14001d9ff40)
	/tmp/buildlet/go/src/testing/testing.go:1494 +0x314
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0x140001352c0, 0x14002e929c0, {0x102aec65b, 0x26}, 0x14002071380, {0x14000349f48, 0x1, 0x1022a00fc?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x46c
golang.org/x/tools/gopls/internal/lsp/regtest.configuredRunner.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:66
golang.org/x/tools/gopls/internal/regtest/completion.TestPostfixSnippetCompletion(0x0?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/completion/postfix_snippet_test.go:440 +0x150
testing.tRunner(0x14002e929c0, 0x102f37a18)

— watchflakes

@adonovan
Copy link
Member

adonovan commented Dec 1, 2023

The first log shows more stuckness waiting for go subprocess on darwin; see #63937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Active
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@adonovan @suzmue @gopherbot