Skip to content

x/build/internal/relui/sign: flaky test crash #55262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Sep 20, 2022 · 6 comments
Closed

x/build/internal/relui/sign: flaky test crash #55262

gopherbot opened this issue Sep 20, 2022 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/build/internal/relui/sign" && test == "" && !`panic: test timed out`

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Contributor Author

gopherbot commented Sep 20, 2022 •
edited
Loading

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/build/internal/relui/sign" && test == "" && !`panic: test timed out`
2022-08-18 17:23 darwin-amd64-12_0 build@80fb06f5 go@3204e62d golang.org/x/build/internal/relui/sign (log) 
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/20 02:10:34 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/20 02:10:34 SigningServer: sent signing request wf-tsk-0
PASS
panic: Log in goroutine after TestUpdateSigningStatusError/non-existant_signing_request has completed: client.stream.Recv() = nil, rpc error: code = Unavailable desc = error reading from server: read tcp 127.0.0.1:49557->127.0.0.1:49556: use of closed network connection; want no error

goroutine 86 [running]:
testing.(*common).logDepth(0xc000336340, {0xc000318180, 0xb6}, 0x3)
	/Users/gopher/workdir/go/src/testing/testing.go:894 +0x4c7
testing.(*common).log(...)
	/Users/gopher/workdir/go/src/testing/testing.go:876
testing.(*common).Logf(0xc000336340, {0x15fa798?, 0xc0003e8fd0?}, {0xc000058fa8?, 0xc0003ea400?, 0x16b91e0?})
	/Users/gopher/workdir/go/src/testing/testing.go:927 +0x5a
golang.org/x/build/internal/relui/sign.fakeSigningServerClient.func1()
	/Users/gopher/workdir/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:105 +0x168
created by golang.org/x/build/internal/relui/sign.fakeSigningServerClient
	/Users/gopher/workdir/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:94 +0x185
2022-08-19 18:55 darwin-arm64-12 build@ac3415dc go@27ced96c golang.org/x/build/internal/relui/sign (log) 
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/19 14:59:30 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/19 14:59:30 SigningServer: sent signing request wf-tsk-0
PASS
panic: Log in goroutine after TestUpdateSigningStatusError/non-existant_signing_request has completed: client.stream.Recv() = nil, rpc error: code = Unavailable desc = error reading from server: EOF; want no error

goroutine 46 [running]:
testing.(*common).logDepth(0x1400008b860, {0x140004280e0, 0x6e}, 0x3)
	/tmp/buildlet/go/src/testing/testing.go:887 +0x3d8
testing.(*common).log(...)
	/tmp/buildlet/go/src/testing/testing.go:869
testing.(*common).Logf(0x1400008b860, {0x104e8775a?, 0x1400009d2c0?}, {0x14000515fb0?, 0x0?, 0x2?})
	/tmp/buildlet/go/src/testing/testing.go:920 +0x5c
golang.org/x/build/internal/relui/sign.fakeSigningServerClient.func1()
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:105 +0x158
created by golang.org/x/build/internal/relui/sign.fakeSigningServerClient
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:94 +0x158
2022-08-19 19:01 linux-amd64 build@7cf3efd5 go@cd528184 golang.org/x/build/internal/relui/sign (log) 
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-2-taskname-request-2-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-3-taskname-request-3-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-4-taskname-request-4-1
2022/08/22 23:23:01 SigningServer: sent signing request workflow-request-1-taskname-request-1-1
2022/08/22 23:23:01 SigningServer: sent signing request wf-tsk-0
PASS
panic: Log in goroutine after TestUpdateSigningStatusError/non-existant_signing_request has completed: client.stream.Recv() = nil, rpc error: code = Unavailable desc = error reading from server: EOF; want no error

goroutine 13 [running]:
testing.(*common).logDepth(0xc00059c1a0, {0xc00017e000, 0x6e}, 0x3)
	/workdir/go/src/testing/testing.go:894 +0x4c7
testing.(*common).log(...)
	/workdir/go/src/testing/testing.go:876
testing.(*common).Logf(0xc00059c1a0, {0x9fa98d?, 0x0?}, {0xc000415fa8?, 0x0?, 0x0?})
	/workdir/go/src/testing/testing.go:927 +0x5a
golang.org/x/build/internal/relui/sign.fakeSigningServerClient.func1()
	/workdir/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:105 +0x168
created by golang.org/x/build/internal/relui/sign.fakeSigningServerClient
	/workdir/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:94 +0x185

— watchflakes

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@rsc rsc moved this to Done in Test Flakes Sep 20, 2022
@gopherbot gopherbot reopened this Jul 21, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/build/internal/relui/sign" && test == "" && !`panic: test timed out`
2023-07-20 21:16 linux-amd64-race build@04b8c053 go@8abc6e25 x/build/internal/relui/sign (log) 
2023/07/21 00:42:32 SigningServer: a client connected (iap = &{Email:accounts.google.com:example@gmail.com ID:accounts.google.com:randomuuidstuff})
2023/07/21 00:42:32 SigningServer: successfully round-tripped message="fda72b5e-c846-47ea-8691-4bd8875bc034" in 6.524803ms:
  req = message_id:"fda72b5e-c846-47ea-8691-4bd8875bc034" sign:{build_type:BUILD_TYPE_MACOS gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"fda72b5e-c846-47ea-8691-4bd8875bc034" started:{job_id:"bac76eb2-1f2f-42bc-bcb1-0a609f558495"}
2023/07/21 00:42:32 SigningServer: successfully round-tripped message="59ed524d-b209-47f6-9104-5d806aa5a164" in 6.515838ms:
  req = message_id:"59ed524d-b209-47f6-9104-5d806aa5a164" sign:{build_type:BUILD_TYPE_GPG gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"59ed524d-b209-47f6-9104-5d806aa5a164" started:{job_id:"b038ab0b-5aab-452f-a121-ffef08157303"}
2023/07/21 00:42:32 SigningServer: successfully round-tripped message="1d720a10-f296-4f06-b57d-417e1dc75c7c" in 6.4417ms:
  req = message_id:"1d720a10-f296-4f06-b57d-417e1dc75c7c" sign:{build_type:BUILD_TYPE_WINDOWS gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"1d720a10-f296-4f06-b57d-417e1dc75c7c" started:{job_id:"d2e7cf6c-84c3-4ea9-9be5-9ca9e5790c2c"}
...
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1595 +0x238
  testing.runTests()
      /workdir/go/src/testing/testing.go:2052 +0x896
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1925 +0xb57
  main.main()
      _testmain.go:49 +0x2bd
==================
FAIL

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/build/internal/relui/sign" && test == "" && !`panic: test timed out`
2023-09-19 17:00 linux-amd64-longtest-race build@c8fdba98 go@da8f406f x/build/internal/relui/sign (log) 
2023/09/20 18:12:14 SigningServer: a client connected (iap = &{Email:accounts.google.com:example@gmail.com ID:accounts.google.com:randomuuidstuff})
2023/09/20 18:12:14 SigningServer: successfully round-tripped message="c83ce15f-261a-47d8-af79-a2695847da69" in 6.321568ms:
  req = message_id:"c83ce15f-261a-47d8-af79-a2695847da69"  sign:{build_type:BUILD_TYPE_GPG  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"c83ce15f-261a-47d8-af79-a2695847da69"  started:{job_id:"23f744e3-650b-4ff9-b375-89503d55a638"}
2023/09/20 18:12:14 SigningServer: successfully round-tripped message="04ddebaa-ac47-4af1-a9be-0768adf75f94" in 6.304027ms:
  req = message_id:"04ddebaa-ac47-4af1-a9be-0768adf75f94"  sign:{build_type:BUILD_TYPE_MACOS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"04ddebaa-ac47-4af1-a9be-0768adf75f94"  started:{job_id:"6d81c0cf-6215-43ba-8d43-e9248f8700cb"}
2023/09/20 18:12:14 SigningServer: successfully round-tripped message="38000373-77fd-4fd7-857c-41cb8e7b4351" in 6.455525ms:
  req = message_id:"38000373-77fd-4fd7-857c-41cb8e7b4351"  sign:{build_type:BUILD_TYPE_WINDOWS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"38000373-77fd-4fd7-857c-41cb8e7b4351"  started:{job_id:"46728b15-b17c-4580-a477-fec021a3f2de"}
...
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1593 +0x21a
  testing.runTests()
      /workdir/go/src/testing/testing.go:2050 +0x896
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1923 +0xb57
  main.main()
      _testmain.go:49 +0x2bd
==================
FAIL

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/build/internal/relui/sign" && test == "" && !`panic: test timed out`
2023-10-06 19:55 linux-amd64-race build@a3af2980 go@ad9e6edf x/build/internal/relui/sign (log) 
2023/10/09 22:35:00 SigningServer: a client connected (iap = &{Email:accounts.google.com:example@gmail.com ID:accounts.google.com:randomuuidstuff})
2023/10/09 22:35:00 SigningServer: successfully round-tripped message="3230943d-0104-4f6d-a49c-5eec9a47ac4b" in 4.520101ms:
  req = message_id:"3230943d-0104-4f6d-a49c-5eec9a47ac4b"  sign:{build_type:BUILD_TYPE_MACOS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"3230943d-0104-4f6d-a49c-5eec9a47ac4b"  started:{job_id:"1f377511-6aa1-42f2-9064-408b8f94ca78"}
2023/10/09 22:35:00 SigningServer: successfully round-tripped message="6437e61b-c743-4317-859d-77dc0a2c0b32" in 4.520924ms:
  req = message_id:"6437e61b-c743-4317-859d-77dc0a2c0b32"  sign:{build_type:BUILD_TYPE_WINDOWS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"6437e61b-c743-4317-859d-77dc0a2c0b32"  started:{job_id:"36842c9b-83fd-4f5e-9843-7f50b20a0d94"}
2023/10/09 22:35:00 SigningServer: successfully round-tripped message="36605d5c-e31d-4ba9-baf3-47be9afacef2" in 4.227995ms:
  req = message_id:"36605d5c-e31d-4ba9-baf3-47be9afacef2"  sign:{build_type:BUILD_TYPE_GPG  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"36605d5c-e31d-4ba9-baf3-47be9afacef2"  started:{job_id:"a7dff2cd-dc7d-4a15-ac54-f7f603d03208"}
...
      /workdir/go/src/testing/testing.go:1593 +0x21a
  testing.runTests()
      /workdir/go/src/testing/testing.go:2050 +0x8b6
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1923 +0xde5
  main.main()
      _testmain.go:49 +0x2bd
==================
2023/10/09 22:35:00 SigningServer: a client disconnected after 10.259033ms (err = context canceled)
FAIL

— watchflakes

@dmitshur dmitshur moved this from Done to Active in Test Flakes May 16, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/585422 mentions this issue: internal/relui/sign: re-enable non-existent signing request test

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 16, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rsc @dmitshur @gopherbot