Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mod/zip: TestVCS failures without useful output #55250

Closed
gopherbot opened this issue Sep 20, 2022 · 4 comments
Closed

x/mod/zip: TestVCS failures without useful output #55250

gopherbot opened this issue Sep 20, 2022 · 4 comments
Assignees
@bcmills
Labels
modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Sep 20, 2022 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/mod/zip" && test == "TestVCS" && date < "2023-01-01"

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022 •
edited

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/mod/zip" && test == "TestVCS"
2022-09-07 13:59 linux-amd64-longtest mod@02c99138 go@4c414c76 golang.org/x/mod/zip.TestVCS (log) 
--- FAIL: TestVCS (0.00s)
    --- FAIL: TestVCS/golang.org_x_net@v0.0.0-20191014212845-da9a3fd4c582 (131.80s)
        zip_test.go:1279: failed to download zip from repository (repeated failure): fetch -f --depth=1 origin da9a3fd4c5820e74b24a6cb7fb438dc9b0dd377c:refs/dummy: exit status 128
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint: 	git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
...
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint: 	git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint: 
hint: 	git branch -m <name>

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@bcmills
Copy link
Contributor

bcmills commented Sep 20, 2022 •
edited by rsc

The root cause of this is likely #50541, but the test should be fixed to log the actual failures instead of (just) “repeated failure”.

@gopherbot gopherbot changed the title x/mod/zip: flaky TestVCS x/mod/zip: TestVCS failures Sep 20, 2022
@bcmills bcmills self-assigned this Sep 21, 2022
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 21, 2022
@bcmills bcmills changed the title x/mod/zip: TestVCS failures x/mod/zip: TestVCS failures without useful output Sep 21, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/432475 mentions this issue: zip: expand logging and use t.TempDir and t.Cleanup in test helpers

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/mod/zip" && test == "TestVCS"
2023-05-17 15:46 linux-amd64-longtest-race mod@e7bea8f1 go@5ffdc1f1 x/mod/zip.TestVCS (log) 
--- FAIL: TestVCS (0.00s)
    --- FAIL: TestVCS/golang.org_x_talks@v0.0.0-20191010201600-067e0d331fee (83.65s)
        zip_test.go:1327: /usr/bin/git init --bare
        zip_test.go:1344: /usr/bin/git remote add origin -- https://go.googlesource.com/talks
        zip_test.go:1353: exit status 128: /usr/bin/git fetch -f --depth=1 origin 067e0d331feee4f8d0fa17d47444db533bd904e7:refs/dummy
            15:57:10.432027 http.c:756              == Info: Couldn't find host go.googlesource.com in the .netrc file; using defaults
            15:57:10.436145 http.c:756              == Info:   Trying 209.85.147.82:443...
            15:57:10.437204 http.c:756              == Info: Connected to go.googlesource.com (209.85.147.82) port 443 (#0)
            15:57:10.494546 http.c:756              == Info: found 387 certificates in /etc/ssl/certs
            15:57:10.494641 http.c:756              == Info: ALPN, offering h2
...
            15:58:34.047371 http.c:703              <= Recv header, 0000000021 bytes (0x00000015)
            15:58:34.047373 http.c:715              <= Recv header: x-xss-protection: 0
            15:58:34.047376 http.c:703              <= Recv header, 0000000037 bytes (0x00000025)
            15:58:34.047378 http.c:715              <= Recv header: date: Tue, 23 May 2023 15:58:34 GMT
            15:58:34.047382 http.c:703              <= Recv header, 0000000002 bytes (0x00000002)
            15:58:34.047385 http.c:715              <= Recv header:
            15:58:34.047432 http.c:756              == Info: Connection #0 to host go.googlesource.com left intact
            error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502
            fatal: error reading section header 'shallow-info'
        zip_test.go:1222: failed to download zip from repository (repeated failure): exit status 128

— watchflakes

@gopherbot gopherbot reopened this May 23, 2023
@bcmills bcmills closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot