Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/playground/socket: TestLimiter failures due to arbitrary timeout #55238

Closed
gopherbot opened this issue Sep 20, 2022 · 11 comments
Closed

x/tools/playground/socket: TestLimiter failures due to arbitrary timeout #55238

gopherbot opened this issue Sep 20, 2022 · 11 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Sep 20, 2022 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/tools/playground/socket" && test == "TestLimiter"

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022 •
edited

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/playground/socket" && test == "TestLimiter"
2022-09-15 19:17 openbsd-386-68 tools@cdd69867 go@19d792c1 golang.org/x/tools/playground/socket.TestLimiter (log) 
--- FAIL: TestLimiter (0.41s)
    socket_test.go:75: process wasn't killed after reaching limit

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/playground/socket: flaky TestLimiter x/tools/playground/socket: TestLimiter failures Sep 20, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/playground/socket" && test == "TestLimiter"
2022-10-06 17:35 openbsd-386-70 tools@15525299 go@9dfadf91 x/tools/playground/socket.TestLimiter (log) 
--- FAIL: TestLimiter (0.14s)
    socket_test.go:75: process wasn't killed after reaching limit
2022-10-11 21:42 openbsd-386-70 tools@19a5504f go@947091d3 x/tools/playground/socket.TestLimiter (log) 
--- FAIL: TestLimiter (0.14s)
    socket_test.go:75: process wasn't killed after reaching limit

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/playground/socket" && test == "TestLimiter"
2022-11-02 21:32 openbsd-386-68 tools@039b24b6 go@a367981b x/tools/playground/socket.TestLimiter (log) 
--- FAIL: TestLimiter (0.14s)
    socket_test.go:75: process wasn't killed after reaching limit

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/playground/socket" && test == "TestLimiter"
2022-11-04 18:06 openbsd-386-68 tools@39c2fd8b go@156bf3dd x/tools/playground/socket.TestLimiter (log) 
--- FAIL: TestLimiter (0.24s)
    socket_test.go:75: process wasn't killed after reaching limit

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/playground/socket" && test == "TestLimiter"
2022-11-04 18:06 openbsd-amd64-68 tools@39c2fd8b go@7e88b866 x/tools/playground/socket.TestLimiter (log) 
--- FAIL: TestLimiter (0.20s)
    socket_test.go:75: process wasn't killed after reaching limit

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/playground/socket" && test == "TestLimiter"
2022-11-15 20:28 openbsd-386-68 tools@6e8da3fe go@d96e5847 x/tools/playground/socket.TestLimiter (log) 
--- FAIL: TestLimiter (0.31s)
    socket_test.go:75: process wasn't killed after reaching limit

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022 •
edited

These failures all seem to be on OpenBSD builders.

@golang/openbsd: this looks like a possible platform bug.

(Updated the watchflakes pattern so that it will file a new issue if this occurs on other platforms.)

@bcmills bcmills changed the title x/tools/playground/socket: TestLimiter failures x/tools/playground/socket: TestLimiter failures on OpenBSD Nov 17, 2022
@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

Actually, this looks like yet another flaky test due to an arbitrary timeout. 😩

https://cs.opensource.google/go/x/tools/+/master:playground/socket/socket_test.go;l=74;drc=d33bae44145976eef532d701e198661ce80178e1

@bcmills bcmills changed the title x/tools/playground/socket: TestLimiter failures on OpenBSD x/tools/playground/socket: TestLimiter failures due to arbitrary timeout Nov 17, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/451598 mentions this issue: playground/socket: eliminate an arbitrary timeout in TestLimiter

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

(See previously #18275.)

@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 17, 2022
@bcmills bcmills self-assigned this Nov 17, 2022
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 17, 2022
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2022
@gopherbot

This comment was marked as resolved.

Sign in to view
@gopherbot gopherbot reopened this Nov 21, 2022
@bcmills bcmills closed this as completed Nov 21, 2022
@bcmills bcmills mentioned this issue Nov 21, 2022
Closed
@golang golang locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot